-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt TS projects #3565
Adopt TS projects #3565
Conversation
@@ -70,7 +70,6 @@ | |||
"@rollup/plugin-babel": "^6.0.3", | |||
"@rollup/plugin-node-resolve": "^15.1.0", | |||
"@testing-library/dom": "^10.1.0", | |||
"@testing-library/jest-dom": "^6.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unused, looks like the browser integration implements the same features.
"declaration": true, | ||
"declarationMap": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why we had declarationMap
enabled, we don't ship them.
@@ -31,12 +31,12 @@ jobs: | |||
run: npm i | |||
- name: Biome | |||
run: node --run biome:ci | |||
- name: Typecheck | |||
run: node --run typecheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's a bug with the ts eslint plugin, but @typescript-eslint/no-unsafe-return
fails in test/website files unless the src
project is already built 🤔
https://kettanaito.com/blog/one-thing-nobody-explained-to-you-about-typescript
https://www.typescriptlang.org/docs/handbook/project-references.html