Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --rdg-sign variable and use dir pseudo-class #3561

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Remove --rdg-sign variable and use dir pseudo-class #3561

merged 2 commits into from
Jul 30, 2024

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 self-assigned this Jul 30, 2024
@amanmahajan7 amanmahajan7 marked this pull request as ready for review July 30, 2024 20:42
nstepien
nstepien reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@nstepien nstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work in all browsers now?
Is this the only place where we use --rdg-sign?

src/style/core.ts Outdated Show resolved Hide resolved
@amanmahajan7 @nstepien
Update src/style/core.ts
27d403e 
Co-authored-by: Nicolas Stepien <[email protected]>
@amanmahajan7 amanmahajan7 enabled auto-merge (squash) July 30, 2024 21:24
@amanmahajan7 amanmahajan7 merged commit 9675973 into main Jul 30, 2024
3 checks passed
@amanmahajan7 amanmahajan7 deleted the am-dir branch July 30, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstepien nstepien nstepien approved these changes

Assignees

@amanmahajan7 amanmahajan7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanmahajan7 @nstepien