Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix summary row position and remove callback dependency #2335

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Fix summary row position and remove callback dependency #2335

merged 2 commits into from
Mar 16, 2021

Conversation

amanmahajan7
Copy link
Contributor

@amanmahajan7 amanmahajan7 commented Mar 16, 2021 •
edited
Loading

Before
image

After
image

@amanmahajan7 amanmahajan7 changed the title Fix summary row position Fix summary row position and remove callback dependency Mar 16, 2021
@amanmahajan7 amanmahajan7 marked this pull request as ready for review March 16, 2021 10:16
@amanmahajan7 amanmahajan7 self-assigned this Mar 16, 2021
@amanmahajan7 amanmahajan7 requested a review from nstepien March 16, 2021 10:17
nstepien
nstepien approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@nstepien nstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: nice!

@amanmahajan7 amanmahajan7 merged commit 00fa83c into canary Mar 16, 2021
@amanmahajan7 amanmahajan7 deleted the summary-row-height branch March 16, 2021 10:20
@amanmahajan7 amanmahajan7 mentioned this pull request Mar 24, 2021
Closed
gernotkogler pushed a commit to Garaio-REM/react-data-grid that referenced this pull request May 13, 2021
@amanmahajan7 @gernotkogler
Fix summary row position and remove callback dependency (adazzle#2335)
ce15285 
* Fix summary row position

* Remove dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstepien nstepien nstepien approved these changes

Assignees

@amanmahajan7 amanmahajan7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanmahajan7 @nstepien