-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow customizing the key property type #2311
Conversation
@amanmahajan7 can you comment on if is going to be accepted or if there a problem with the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea.
Can you please also add the generic to the default export, it's at the end of DataGrid.tsx
.
Co-authored-by: Nicolas Stepien <[email protected]>
Please also add the generic to the default export at the end of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks!
Thank you! 🎉 |
* Allow customizing the key property * Update DataGrid.tsx * Update DataGrid.tsx * Update src/DataGrid.tsx Co-authored-by: Nicolas Stepien <[email protected]> * update * Update src/DataGrid.tsx Co-authored-by: Nicolas Stepien <[email protected]>
Why? This fails:
because onSelectedRowsChange was expected to receive all the properties React.Key has, eg number, which is not possible/desired.