Boost layout performance #2015
Boost layout performance #2015
Conversation
|
I've also fixed summary rows positioning so they're always at the bottom of the grid, even if we don't have enough rows to fill the available space. Before:
After:
|
| @@ -47,6 +48,7 @@ function Row<R, SR = unknown>({ | |||
| onDragEnter={wrapEvent(handleDragEnter, onDragEnter)} | |||
| onDragOver={wrapEvent(handleDragOver, onDragOver)} | |||
| onDrop={wrapEvent(preventDefault, onDrop)} | |||
| style={{ top }} | |||
There was a problem hiding this comment.
Just 1 concern here. Let's say if the user has their own RowRenderer and they forget to add this top to their wrapper. The whole layout would be messed up, right?
There was a problem hiding this comment.
Yup. If you pass top back to Row, or to your wrapper, you'll be fine though.
There was a problem hiding this comment.
To be honest, I don't know if this worth it given by 5ms to 3ms improvement. As it makes the RowRenderer error prone. And I bet people will create issues for this case when they use CustomRowRenderer.
There was a problem hiding this comment.
Aren't custom row renderers already error-prone?
|
@nstepien can you catchup? |
|
@amanmahajan7 Done. |
Since we know all the widths/heights/positions of rows/cells, we can absolutely position the rows, and replace two padding divs with very dynamic
heights, with one div with a more staticheight.This improves layout perf from ~5ms to ~3.1ms on my machine. Might also improve more than layout rendering, not sure.
Before:
After: