Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added test for timepicker #86

Merged
merged 1 commit into from
Oct 12, 2020
Merged

test: added test for timepicker #86

merged 1 commit into from
Oct 12, 2020

Conversation

anuraghazra
Copy link
Contributor

No description provided.

@anuraghazra anuraghazra added the test 🧪 Pulls requests or issues related to testing label Oct 12, 2020
@netlify
Copy link

netlify bot commented Oct 12, 2020

Deploy preview for renderless-components ready!

Built with commit 8ec421f

https://deploy-preview-86--renderless-components.netlify.app

@@ -8,7 +8,7 @@ export type ColumnType = "hour" | "minute" | "meridian";

export interface TimePickerColumnInitialState extends ValueBase<Date> {
visible?: boolean;
type?: ColumnType;
columnType?: ColumnType;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the type to columnType because jestdom is throwing erros with because native elements also have type prop.

Copy link
Collaborator

@navin-moorthy navin-moorthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@anuraghazra anuraghazra merged commit 759e100 into master Oct 12, 2020
@anuraghazra anuraghazra deleted the timepicker-tests branch October 12, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test 🧪 Pulls requests or issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants