feat: added segment component #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for renderless-components ready! Built with commit 0c8d022 https://deploy-preview-71--renderless-components.netlify.app |
|
See my DatePicker V3 branch for all the fixes directly I did yesterday. |
anuraghazra
added a commit
that referenced
this pull request
Oct 7, 2020
* chore: wip datepicker * chore: wip style fixes * feat: wip added datepicker * chore: focus on current date on datepicker toggle * chore: minor refactors * fix: datepicker disclosure focus restore not working * refactor: refactored duplicate calendar component * feat: added Tab behaviour in datepicker spinbuttons composite * fix: ensure tabIndex 0 * feat: alt arrowdown to open dropdown * refactor: reorganized & refactored code * fix: datepicker on open focus on selected date * chore: fixed calendar types & dateSegment composite spread * feat: datepicker v3 (#70) * refactor(datepicker): ♻️ organize imports and improve code flow * feat(datepicker): ✨ add controllable date picker * refactor(date-picker): ♻️ bring popover close focus back * fix(date-picker): 🐛 fix focus spin button on focus * fix(date-picker): 🐛 fix outside click moving focus to button * refactor(date-picker): ♻️ arrange imports * refactor(date-picker): 🏷️ update types for Date Segment * fix(date-picker): 🐛 fix focus movements * fix(date-picker): 🐛 fix focus & date values * fix: calendar day value lag & few css improvements Co-authored-by: Anurag <[email protected]> * fix: range calendar start date iso timing lag * chore: datepicker stories improvements (#72) * refactor(date-picker): ♻️ added more stories * refactor(date-picker): ♻️ add disabled styles * feat: added segment component (#71) * feat: added Segment component * refactor: review updates & segment aria label fix * chore: event listener rename * feat: added Segment component to DatePicker * fix: datepicker propagation * refactor: unified DateValue type import & removed extra composite in DatePickerState * chore: fieldvalue fix * chore: removed DOMProps * test: css ignore tests Co-authored-by: Navin Moorthy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted and isolated date segment component to make it more generic and reusable.
We will implement the Segment component to calendar component after merging #70
And this PR should be merged to datepicker-v2 branch #58