-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pluggable Model Integration Interface #738
Draft
calpt
wants to merge
24
commits into
adapter-hub:main
Choose a base branch
from
calpt:dev/interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iter_layers and iter_attentions shouldn't use `getattr` and `hasattr` but instead use `multigetattr` and `multihasattr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drafts a new model integration interface which makes it easier to support new and custom model architectures for selected adapter methods without full model implementation.
This is done with the new
AdapterModelInterface
class that translates from generic model access points to model-specific attribute names.Example usage:
Basic interface for Qwen model:
Extended interface
Additionally, the interface provides optional attributes that enable (almost) full bottleneck adapter support. Without the extended interface, bottleneck adapter support is very limited.
Example for Gemma2:
Additional novelties
AdapterMethod
as an enum of all supported adapter method types (e.g.AdapterMethod.bottleneck
,AdapterMethod.lora
, ...)supports_adapter()
method for easy checking whether a model instance supports a certain adapter method. This method can receive anAdapterMethod
string or a config object:State of implementation
Supported adapter types:
is_parallel
, via extended interfaceoriginal_ln_before=True
, via extended interfaceoriginal_ln_after=False
(e.g. used forAdapterPlusConfig
)Supported features:
Not to be supported: