Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Refactor flwr ls table formatter #4611

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(framework) Refactor flwr ls table formatter #4611

wants to merge 3 commits into from

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Dec 2, 2024 •
edited
Loading

Split the logic of formatting the Run from creating a rich.Table. The formatted Run will be used later to create a JSON output.

Merge before:

@chongshenng chongshenng marked this pull request as ready for review December 2, 2024 12:40
@chongshenng chongshenng mentioned this pull request Dec 3, 2024
Open
panh99
panh99 reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few minor comments.

src/py/flwr/cli/ls.py Outdated Show resolved Hide resolved
src/py/flwr/cli/ls.py Outdated Show resolved Hide resolved
src/py/flwr/cli/ls.py Outdated Show resolved Hide resolved
panh99
panh99 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panh99 panh99 panh99 approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongshenng @panh99