Skip to content

feat(examples) Update C++ example #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll charlesbvll marked this pull request as ready for review October 1, 2024 10:55
@jafermarq
Copy link
Contributor

@charlesbvll, some additional changes are needed to make it compatible with flwr>=1.11.0, the main one being that flower-server-app does not accept a reference to a ServerApp as input argument. Instead, it needs to be read from a pyproject.toml. Also, in the README.md, flwr-superlink should be replaced with flower-superlink.

@jafermarq
Copy link
Contributor

@charlesbvll , the example looks ready to me. But we might need to merge first the changes in src/cc/flwr first in a separate PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants