Skip to content

Commit

Permalink
refactor(framework) Correct numpy client fit error message
Browse files Browse the repository at this point in the history
  • Loading branch information
William committed Dec 10, 2024
1 parent 8fc2f9b commit 47dabdc
Showing 1 changed file with 9 additions and 11 deletions.
20 changes: 9 additions & 11 deletions src/py/flwr/client/numpy_client_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,11 @@ def test_fit_return_type() -> None:
)

# Assert
assert isinstance(parameters, list) # NDArrays is a list
assert all(
isinstance(p, np.ndarray) and p.dtype.kind in {"f", "i", "u"}
for p in parameters
)
# Check if parameters is a list and all elements are np.ndarray
assert isinstance(parameters, list)
assert all(isinstance(p, np.ndarray) for p in parameters)

# Check other return types
assert isinstance(num_examples, int)
assert isinstance(metrics, dict)
assert all(
Expand Down Expand Up @@ -212,11 +212,9 @@ def test_get_parameters_return_type() -> None:
parameters = client.get_parameters(config={})

# Assert
assert isinstance(parameters, list) # NDArrays is a list
assert all(
isinstance(p, np.ndarray) and p.dtype.kind in {"f", "i", "u"}
for p in parameters
)
# Check if parameters is a list and all elements are np.ndarray
assert isinstance(parameters, list)
assert all(isinstance(p, np.ndarray) for p in parameters)


def test_get_properties_return_type() -> None:
Expand All @@ -232,4 +230,4 @@ def test_get_properties_return_type() -> None:
assert all(isinstance(k, str) for k in properties.keys())
assert all(
isinstance(v, (bool, bytes, float, int, str)) for v in properties.values()
)
)

0 comments on commit 47dabdc

Please sign in to comment.