Update Python bindings to support Python 3 (tested on Python 3.7) #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, this is a great project! Thanks for making it open source.
I played around with it a bit, and I'd like to make a PR to update the python binding to support 3.X, as Python 2 is deprecated as of this year.
The main changes required were porting some C Python extensions over. Specifically, the
Py_InitModule
constructor has been replaced. Now I create aPyModuleDef
structure and then pass a reference to it toPyModule_Create
.Additionally, I had to change the entry point of the compilation, by explicitly converting the application argument from
char
towchar_t
.Other minor changes include:
.gitignore
to ignore precompiled python files.requirements.txt
file forpip
.example.py
(scikits.audiolab.wavread
is also deprecated).