Repository navigation
fix(web): usage limit banner no longer flashes on resume at reset - #389
Merged
Merged
Conversation
The details button sat in the action row, so showing it wrapped the buttons, the reset time then fit, and the button removed itself. That loop flashed the banner between one line and two. The button now stays out of the row, and the reset time sits under the title so it stays readable. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clicking Resume at reset changed the usage-limit notice from a short line into a longer reset sentence. The details button for that sentence sat in the action row, so showing it wrapped the buttons onto a second line, the text then fit, and the button removed itself. The banner flashed between those two layouts.
The details button now stays out of the row, and the reset time sits under the title so it stays readable instead of truncating against the buttons.
Test plan
vp test run --project browser src/components/chat/ComposerBannerStack.browser.test.tsx(the new case fails on the old layout at 720px, height 83px vs 55px)Grok 4.7 via Cursor in T3 Code.
Made with Cursor