Repository navigation
feat(notion): app.notion.com links attach, and the integration can be turned off - #194
Merged
Merged
Conversation
… turned off Pasted notion.com page links (the format Notion's "Copy link" now produces) were not recognised, so they stayed as text. They now parse like notion.so and notion.site links. Adds an "Enable Notion integration" setting, mirroring Slack's: turning it off keeps pasted Notion links as links without setup prompts and hides Notion attach actions on web, desktop, and mobile, keeping the account. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pasting a Notion link copied from Notion today (
https://app.notion.com/p/<workspace>/<title>-<id>?source=copy_link) left it as plain text: the page-link parser only acceptednotion.soandnotion.sitehosts. There was also no way to turn the Notion integration off the way Slack can be.Fix
parseNotionPageIdacceptsnotion.comand its subdomains, so those links become Notion page chips on paste or when typed, like Slack links.enableNotionIntegrationenvironment setting (default on), with a switch under Settings → Integrations → Notion. When off:#menu Notion tab, and the picker dialog are hidden on web/desktopdocs/fork-differences.mdupdated.Tests: parser cases for
app.notion.com/www.notion.com(and a lookalike-domain rejection), settings decode/persist for the new flag (contracts + server), and resolver tests showing a pastedapp.notion.comlink attaches and a disabled integration makes no request and shows no prompt.Surfaces: web/desktop (paste, typed link, attach menu, command palette,
#menu, picker), mobile (attach menu). Providers unaffected: the snapshot path is unchanged.Model: Claude Opus 5.5 via Claude Code in T3 Code.
🤖 Generated with Claude Code