Fix extraction failure on Windows due to case-sensitive path comparison#988
Merged
adamhathcock merged 5 commits intomasterfrom Oct 28, 2025
Merged
Fix extraction failure on Windows due to case-sensitive path comparison#988adamhathcock merged 5 commits intomasterfrom
adamhathcock merged 5 commits intomasterfrom
Conversation
- Add PathComparison property that uses OrdinalIgnoreCase on Windows and Ordinal on Unix - Update all path comparison checks in ExtractionMethods to use PathComparison - Add comprehensive tests for extraction with case-insensitive paths - Ensure security check for path traversal still works correctly Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
…ection - Replace Environment.OSVersion.Platform with RuntimeInformation.IsOSPlatform(OSPlatform.Windows) - Clarify test comment about platform-specific behavior - Add using System.Runtime.InteropServices for RuntimeInformation Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix entry writing error for Windows Service in LocalSystem account
Fix extraction failure on Windows due to case-sensitive path comparison
Oct 28, 2025
adamhathcock
approved these changes
Oct 28, 2025
Owner
|
@copilot format this code |
Contributor
Author
The code has been formatted with CSharpier. All 432 files pass the formatting check with no issues. |
This was referenced Nov 28, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
This was referenced Jan 5, 2026
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path.GetFullPath()on Windows can return paths with different casing than what's on disk (e.g.,system32vsSystem32under LocalSystem account). The security check validating extraction paths was using case-sensitive comparison, causing false positives that blocked legitimate extractions.Changes:
PathComparisonproperty returningStringComparison.OrdinalIgnoreCaseon Windows,StringComparison.Ordinalon UnixStringComparison.Ordinalin 4 path validation checks (sync + async methods)RuntimeInformation.IsOSPlatform(OSPlatform.Windows)for platform detectionExample:
Path traversal security checks remain fully functional.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.