More cleanup #958
Closed
More cleanup #958
Annotations
1 error and 10 warnings
|
|
|
src/SharpCompress/Readers/Rar/MultiVolumeRarReader.cs#L56
'MultiVolumeStreamEnumerator' contains field 'nextReadableStreams' that is of IDisposable type 'IEnumerator<Stream>', but it is never disposed. Change the Dispose method on 'MultiVolumeStreamEnumerator' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
|
src/SharpCompress/Readers/Rar/RarReader.cs#L17
'RarReader' contains field 'volume' that is of IDisposable type 'RarVolume?', but it is never disposed. Change the Dispose method on 'RarReader' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
|
src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs#L53
'item != null' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
src/SharpCompress/Readers/Rar/RarReader.cs#L25
Change RarReader.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
|
src/SharpCompress/Readers/Rar/SingleVolumeRarReader.cs#L9
'SingleVolumeRarReader' contains field 'stream' that is of IDisposable type 'Stream', but it is never disposed. Change the Dispose method on 'SingleVolumeRarReader' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
|
src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs#L193
Call System.IDisposable.Dispose on object created by 'new BinaryReader(stream)' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
src/SharpCompress/Archives/AbstractArchive.cs#L90
Change AbstractArchive<TEntry, TVolume>.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
|
|
src/SharpCompress/Archives/Tar/TarArchive.cs#L121
Call System.IDisposable.Dispose on object created by 'new BinaryReader(stream)' before all references to it are out of scope (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2000)
|
|
src/SharpCompress/Writers/Zip/ZipWriter.cs#L314
'ZipWritingStream' contains field 'writer' that is of IDisposable type 'ZipWriter', but it is never disposed. Change the Dispose method on 'ZipWritingStream' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
|
src/SharpCompress/Writers/Zip/ZipWriter.cs#L317
'ZipWritingStream' contains field 'counting' that is of IDisposable type 'SharpCompressStream?', but it is never disposed. Change the Dispose method on 'ZipWritingStream' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
|
The logs for this run have expired and are no longer available.
Loading