Added ArgumentException to Archive.Open implementations#931
Merged
adamhathcock merged 4 commits intoadamhathcock:masterfrom Jul 22, 2025
Merged
Conversation
Contributor
Author
|
No worries. This also addresses #927. |
This was referenced Oct 13, 2025
This was referenced Oct 24, 2025
This was referenced Nov 3, 2025
This was referenced Nov 10, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
This was referenced Jan 5, 2026
This was referenced Jan 12, 2026
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This minor change affects the
Openmethods of each Archive type.The change is only a condition, determining whether or not the
Streamis seekable, and throws anArgumentExceptionif that's the case.I'd though of implementing this, too, but @Morilli gave me the final motivation.