Skip to content

Added ArgumentException to Archive.Open implementations#931

Merged
adamhathcock merged 4 commits intoadamhathcock:masterfrom
SimonCahill:feat/add-throw-on-unseekable-stream
Jul 22, 2025
Merged

Added ArgumentException to Archive.Open implementations#931
adamhathcock merged 4 commits intoadamhathcock:masterfrom
SimonCahill:feat/add-throw-on-unseekable-stream

Conversation

@SimonCahill
Copy link
Contributor

This minor change affects the Open methods of each Archive type.

The change is only a condition, determining whether or not the Stream is seekable, and throws an ArgumentException if that's the case.

I'd though of implementing this, too, but @Morilli gave me the final motivation.

Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@adamhathcock adamhathcock enabled auto-merge July 22, 2025 10:50
@SimonCahill
Copy link
Contributor Author

No worries.

This also addresses #927.

@adamhathcock adamhathcock merged commit 3946c3b into adamhathcock:master Jul 22, 2025
2 checks passed
@SimonCahill SimonCahill deleted the feat/add-throw-on-unseekable-stream branch July 22, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments