Implement multipart rar handling for ExtractAllEntries#916
Merged
adamhathcock merged 5 commits intoadamhathcock:masterfrom May 14, 2025
Merged
Implement multipart rar handling for ExtractAllEntries#916adamhathcock merged 5 commits intoadamhathcock:masterfrom
adamhathcock merged 5 commits intoadamhathcock:masterfrom
Conversation
This test tested that skipping over entries using the reader interface for an encrypted multi-volume rar archive worked. However reading those entries doesn't work and the skipping was also not working properly so I believe it's fine to "break" this functionality.
Owner
|
Thanks. I think it's far that you can't skip passworded entries. SOLID archives are supposed to be a continuous stream which needs to be decrypted. |
This was referenced Aug 1, 2025
This was referenced Nov 24, 2025
This was referenced Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One side-effect of the changes here is that skipping over encrypted entries for which the password is not known in a multipart rar file using the reader interface no longer works.
However reading those entries does not work because it isn't currently implemented, and the skipping was bad as well because it would fail to skip all file parts and returned after skipping the first part only, so I think it is fair to remove this functionality.
It could be implemented properly but I think it would take some effort to extract the needed information and perhaps need additional interface methods.