Skip to content

Implement ReadByte for BufferedSubStream #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamhathcock merged 2 commits into from
Feb 17, 2025
Merged

Implement ReadByte for BufferedSubStream #897

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
441147c
Implement ReadByte for BufferedSubStream
Morilli Feb 16, 2025
2411f4f
Merge branch 'master' into bufferedsubstream-readbyte
adamhathcock Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/SharpCompress/IO/BufferedSubStream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,30 @@ public override int Read(byte[] buffer, int offset, int count)
return count;
}

public override int ReadByte()
{
if (BytesLeftToRead == 0)
{
return -1;
}

if (_cacheLength == 0)
{
_cacheOffset = 0;
Stream.Position = origin;
_cacheLength = Stream.Read(_cache, 0, _cache.Length);
origin += _cacheLength;
}

int value = _cache[_cacheOffset];

_cacheOffset++;
_cacheLength--;
BytesLeftToRead--;

return value;
}

public override long Seek(long offset, SeekOrigin origin) => throw new NotSupportedException();

public override void SetLength(long value) => throw new NotSupportedException();
Expand Down