Fix zip entry handling for entries with data descriptors#891
Merged
adamhathcock merged 5 commits intoadamhathcock:masterfrom Jan 28, 2025
Merged
Fix zip entry handling for entries with data descriptors#891adamhathcock merged 5 commits intoadamhathcock:masterfrom
adamhathcock merged 5 commits intoadamhathcock:masterfrom
Conversation
As described in section 4.4.7-4.4.9 of the zip specification when this flag is set the correct values will be in the data descriptor record and in the directory header.
Introduced in af264cd; the test included in that commit passes still.
Contributor
Author
|
Test failures are unrelated and are due to the ubuntu runner using |
Owner
|
Thanks for this. I didn't mean to be executing legacy framework tests on ubuntu. |
This was referenced Aug 1, 2025
This was referenced Nov 24, 2025
This was referenced Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the included test for how this issue surfaces. The missing fields in the local header will now be set from the directory header if the
UsePostDataDescriptorbit is set in the local header's flags.