Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Explode and (un)Reduce #853

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Conversation

gjefferyes
Copy link
Contributor

I added decompression streams for Explode (Zip Type 6) and (un)Reduce (zip Type 2,3,4,5)

@gjefferyes gjefferyes changed the title Added Export and (un)Reduce to sharpCompress Added Explode and (un)Reduce to sharpCompress Jun 25, 2024
@gjefferyes gjefferyes changed the title Added Explode and (un)Reduce to sharpCompress Added Explode and (un)Reduce Jun 25, 2024
@adamhathcock
Copy link
Owner

Thanks for this! Any chance for some minor zip tests?

Also, please run csharpier as a formatter, it's a tool

@gjefferyes
Copy link
Contributor Author

HI,
Yes I did run csharpier over my code before submitting. If there is a code format you are not happy with, maybe I do not have it configured correctly?
Would you like me to also add some test files into ZipReaderTest.cs?

@adamhathcock
Copy link
Owner

Sorry for the delayed reply. Please add tests if you can!

@gjefferyes
Copy link
Contributor Author

I have now added some test files, and unit tests for these added un-compress methods.
Thanks to https://github.com/TwanVanDongen for supplying these test archives.

@adamhathcock adamhathcock enabled auto-merge July 24, 2024 07:27
@adamhathcock adamhathcock disabled auto-merge July 24, 2024 07:27
@adamhathcock adamhathcock self-assigned this Jul 24, 2024
@adamhathcock adamhathcock merged commit 3545693 into adamhathcock:master Jul 24, 2024
0 of 2 checks passed
@adamhathcock
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants