Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for reading comment header for Rar v5 archives #697

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Added support for reading comment header for Rar v5 archives #697

merged 4 commits into from
Sep 30, 2022

Conversation

IngBertolini
Copy link
Contributor

Hello! Like for the Zip archives i tried to add the Comment property in RarVolume, in order to read the comment header from the archive. It only works with Rar v5 archives though

Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and to spec!

Had to look it up as the CMT part was weird but that's what it is.

@adamhathcock adamhathcock merged commit 4f0840b into adamhathcock:master Sep 30, 2022
@IngBertolini IngBertolini deleted the rar_comment branch September 30, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants