Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use System.Buffers Nuget package #478

Merged
merged 2 commits into from
Sep 17, 2019
Merged

Use System.Buffers Nuget package #478

merged 2 commits into from
Sep 17, 2019

Conversation

Bond-009
Copy link
Contributor

No description provided.

@adamhathcock
Copy link
Owner

Please describe why this is necessary for you. I think I did it my way because of platform targeting issues

@Bond-009
Copy link
Contributor Author

@adamhathcock what issues? I did this because it's best practice not to include libs in source control, but via a package manager (i.e Nuget)

@adamhathcock
Copy link
Owner

That’s great and all but the older platforms didn’t like the multi-targeting. Build isn’t passing anyway.

If I go netstandard only then this will be a thing to do. I didn’t take it lightly then choosing to absorbing code instead of a reference

@Bond-009
Copy link
Contributor Author

@adamhathcock Fixed the build

@adamhathcock adamhathcock merged commit 17d5565 into adamhathcock:master Sep 17, 2019
@Bond-009 Bond-009 deleted the buffers branch September 17, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants