Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default zip ver to 20 (deflate/encyption), fixes #164 #236

Merged
merged 1 commit into from
May 22, 2017
Merged

Default zip ver to 20 (deflate/encyption), fixes #164 #236

merged 1 commit into from
May 22, 2017

Conversation

damieng
Copy link
Contributor

@damieng damieng commented May 19, 2017

Sets the default level of '20' for zip files in the ZipCentralDirectoryBlock to match '20' used in Zip Local File Headers at https://github.com/adamhathcock/sharpcompress/blob/master/src/SharpCompress/Writers/Zip/ZipWriter.cs#L162

This makes Microsoft's compression.io library used by NuGet happy (and possibly some other tools)

@damieng
Copy link
Contributor Author

damieng commented May 19, 2017

Let me know if you want any test coverage.

@adamhathcock
Copy link
Owner

I guess ideally there should be a test validating against packaging. Not sure that's possible on netcoreapp. Probably need to make another test project on full framework.

I plan on doing a bit more work then a release Monday to get this and other fixes out.

@damieng
Copy link
Contributor Author

damieng commented May 20, 2017

Thanks for fast turnaround. We could just have a test that checked the fields are the same rather than testing with System.Packaging.

@adamhathcock
Copy link
Owner

Could do. Whatever is easier.

I may explore packinging myself. Integration feel the most valuable when trying to match external programs. Though, in this case, it's being consistent internally was the problem.

Not easy to test this stuff .

@adamhathcock adamhathcock merged commit 3b73464 into adamhathcock:master May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants