Repository navigation
Fix gzip FEXTRA XLEN overflow - #1428
Merged
adamhathcock merged 2 commits intoOct 9, 2026
Merged
Conversation
Owner
|
Gonna review this but I'd like this targeting the release branch |
syrok0010
force-pushed
the
fix/gzip-extra-field-length
branch
from
October 8, 2026 17:23
221f49b to
6c13a99
Compare
Owner
|
Thanks for this! |
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gzip's FEXTRA length (XLEN) is an unsigned 16-bit value. Casting it to
shortturns valid lengths of 32768–65535 into negative values, causing anOverflowExceptionwhen allocating the extra-field buffer in both synchronous and asynchronous decompression.Keep the decoded length as an
intin both paths so the full XLEN range is handled correctly. This is a minimal fix that preserves existing behavior for smaller extra fields and leaves public APIs unchanged.Regression tests verify the decompressed payload for XLEN values of 32767, 32768, and 65535 in both paths. The asynchronous test uses an async-only input stream to ensure it exercises asynchronous reading.
Validation:
Please consider backporting this fix to the 0.50.x release line: the same signed XLEN handling is present in 0.50.4.