Fix usage of ReaderOptions and pre-defined values

src/SharpCompress/Archives/AbstractArchive.cs

@@ -40,7 +40,7 @@ internal AbstractArchive(ArchiveType type, SourceStream sourceStream)
     internal AbstractArchive(ArchiveType type)
     {
         Type = type;
-        ReaderOptions = new();
+        ReaderOptions = ReaderOptions.Default;
         _lazyVolumes = new LazyReadOnlyCollection<TVolume>(Enumerable.Empty<TVolume>());
         _lazyEntries = new LazyReadOnlyCollection<TEntry>(Enumerable.Empty<TEntry>());
         _lazyVolumesAsync = new LazyAsyncReadOnlyCollection<TVolume>(

src/SharpCompress/Archives/ArchiveFactory.Async.cs

@@ -33,7 +33,11 @@ public static ValueTask<IAsyncArchive> OpenAsyncArchive(
     )
     {
         filePath.NotNullOrEmpty(nameof(filePath));
-        return OpenAsyncArchive(new FileInfo(filePath), options, cancellationToken);
+        return OpenAsyncArchive(
+            new FileInfo(filePath),
+            options ?? ReaderOptions.ForFilePath,
+            cancellationToken
+        );
     }
 
     public static async ValueTask<IAsyncArchive> OpenAsyncArchive(

src/SharpCompress/Archives/ArchiveFactory.cs

@@ -37,7 +37,7 @@ public static IWritableArchive<TOptions> CreateArchive<TOptions>()
     public static IArchive OpenArchive(string filePath, ReaderOptions? options = null)
     {
         filePath.NotNullOrEmpty(nameof(filePath));
-        return OpenArchive(new FileInfo(filePath), options);
+        return OpenArchive(new FileInfo(filePath), options ?? ReaderOptions.ForFilePath);
     }
 
     public static IArchive OpenArchive(FileInfo fileInfo, ReaderOptions? options = null)

src/SharpCompress/Archives/Rar/FileInfoRarArchiveVolume.cs

@@ -15,18 +15,17 @@ namespace SharpCompress.Archives.Rar;
 internal class FileInfoRarArchiveVolume : RarVolume
 {
     internal FileInfoRarArchiveVolume(FileInfo fileInfo, ReaderOptions options, int index)
-        : base(StreamingMode.Seekable, fileInfo.OpenRead(), FixOptions(options), index)
+        : base(
+            StreamingMode.Seekable,
+            fileInfo.OpenRead(),
+            options.WithLeaveStreamOpen(false),
+            index
+        )
     {
         FileInfo = fileInfo;
         FileParts = GetVolumeFileParts().ToArray().ToReadOnly();
     }
 
-    private static ReaderOptions FixOptions(ReaderOptions options)
-    {
-        //make sure we're closing streams with fileinfo
-        return options with { LeaveStreamOpen = false };
-    }
-
     internal ReadOnlyCollection<RarFilePart> FileParts { get; }
 
     internal FileInfo FileInfo { get; }

src/SharpCompress/Archives/Rar/RarArchive.Factory.cs

@@ -51,7 +51,7 @@ public static IRarArchive OpenArchive(FileInfo fileInfo, ReaderOptions? readerOp
             new SourceStream(
                 fileInfo,
                 i => RarArchiveVolumeFactory.GetFilePart(i, fileInfo),
-                readerOptions ?? new ReaderOptions()
+                readerOptions ?? ReaderOptions.ForFilePath
             )
         );
     }
@@ -66,7 +66,7 @@ public static IRarArchive OpenArchive(Stream stream, ReaderOptions? readerOption
         }
 
         return new RarArchive(
-            new SourceStream(stream, _ => null, readerOptions ?? new ReaderOptions())
+            new SourceStream(stream, _ => null, readerOptions ?? ReaderOptions.ForExternalStream)
         );
     }
 

src/SharpCompress/Archives/Zip/ZipArchive.Async.cs

@@ -45,7 +45,7 @@ var h in headerFactory.NotNull().ReadSeekableHeaderAsync(volsArray.Last().Stream
                                 s = new SourceStream(
                                     v[0].Stream,
                                     i => i < v.Length ? v[i].Stream : null,
-                                    new ReaderOptions() { LeaveStreamOpen = true }
+                                    ReaderOptions.ForExternalStream
                                 );
                             }
                             else

src/SharpCompress/Archives/Zip/ZipArchive.cs

@@ -86,7 +86,7 @@ protected override IEnumerable<ZipArchiveEntry> LoadEntries(IEnumerable<ZipVolum
                                 s = new SourceStream(
                                     v[0].Stream,
                                     i => i < v.Length ? v[i].Stream : null,
-                                    new ReaderOptions() { LeaveStreamOpen = true }
+                                    ReaderOptions.ForExternalStream
                                 );
                             }
                             else

src/SharpCompress/Common/ExtractionMethods.Async.cs

@@ -90,15 +90,7 @@ public static async ValueTask WriteEntryToFileAsync(
         options ??= new ExtractionOptions();
         if (entry.LinkTarget != null)
         {
-            if (options.SymbolicLinkHandler is not null)
-            {
-                options.SymbolicLinkHandler(destinationFileName, entry.LinkTarget);
-            }
-            else
-            {
-                ExtractionOptions.DefaultSymbolicLinkHandler(destinationFileName, entry.LinkTarget);
-            }
-            return;
+            options.SymbolicLinkHandler?.Invoke(destinationFileName, entry.LinkTarget);
         }
         else
         {

src/SharpCompress/Common/ExtractionMethods.cs

@@ -99,15 +99,7 @@ Action<string, FileMode> openAndWrite
         options ??= new ExtractionOptions();
         if (entry.LinkTarget != null)
         {
-            if (options.SymbolicLinkHandler is not null)
-            {
-                options.SymbolicLinkHandler(destinationFileName, entry.LinkTarget);
-            }
-            else
-            {
-                ExtractionOptions.DefaultSymbolicLinkHandler(destinationFileName, entry.LinkTarget);
-            }
-            return;
+            options.SymbolicLinkHandler?.Invoke(destinationFileName, entry.LinkTarget);
         }
         else
         {

src/SharpCompress/Common/ExtractionOptions.cs

@@ -45,7 +45,7 @@ public sealed record ExtractionOptions : IExtractionOptions
     /// </summary>
     /// <remarks>
     /// <b>Breaking change:</b> Changed from field to init-only property in version 0.40.0.
-    /// The default handler logs a warning message.
+    /// If no handler is provided, symbolic links are silently skipped during extraction.
     /// </remarks>
     public Action<string, string>? SymbolicLinkHandler { get; init; }
 
@@ -58,10 +58,7 @@ public ExtractionOptions() { }
     /// Creates a new ExtractionOptions instance with the specified overwrite behavior.
     /// </summary>
     /// <param name="overwrite">Whether to overwrite existing files.</param>
-    public ExtractionOptions(bool overwrite)
-    {
-        Overwrite = overwrite;
-    }
+    public ExtractionOptions(bool overwrite) => Overwrite = overwrite;
 
     /// <summary>
     /// Creates a new ExtractionOptions instance with the specified extraction path and overwrite behavior.
@@ -102,14 +99,4 @@ public ExtractionOptions(bool extractFullPath, bool overwrite, bool preserveFile
     /// </summary>
     public static ExtractionOptions PreserveMetadata =>
         new() { PreserveFileTime = true, PreserveAttributes = true };
-
-    /// <summary>
-    /// Default symbolic link handler that logs a warning message.
-    /// </summary>
-    public static void DefaultSymbolicLinkHandler(string sourcePath, string targetPath)
-    {
-        Console.WriteLine(
-            $"Could not write symlink {sourcePath} -> {targetPath}, for more information please see https://github.com/dotnet/runtime/issues/24271"
-        );
-    }
 }

src/SharpCompress/Common/GZip/GZipVolume.cs

@@ -5,11 +5,11 @@ namespace SharpCompress.Common.GZip;
 
 public class GZipVolume : Volume
 {
-    public GZipVolume(Stream stream, ReaderOptions? options, int index)
+    public GZipVolume(Stream stream, ReaderOptions options, int index)
         : base(stream, options, index) { }
 
     public GZipVolume(FileInfo fileInfo, ReaderOptions options)
-        : base(fileInfo.OpenRead(), options with { LeaveStreamOpen = false }) { }
+        : base(fileInfo.OpenRead(), options.WithLeaveStreamOpen(false)) { }
 
     public override bool IsFirstVolume => true;
 

src/SharpCompress/Common/Lzw/LzwVolume.cs

@@ -5,11 +5,11 @@ namespace SharpCompress.Common.Lzw;
 
 public class LzwVolume : Volume
 {
-    public LzwVolume(Stream stream, ReaderOptions? options, int index)
+    public LzwVolume(Stream stream, ReaderOptions options, int index)
         : base(stream, options, index) { }
 
     public LzwVolume(FileInfo fileInfo, ReaderOptions options)
-        : base(fileInfo.OpenRead(), options with { LeaveStreamOpen = false }) { }
+        : base(fileInfo.OpenRead(), options.WithLeaveStreamOpen(false)) { }
 
     public override bool IsFirstVolume => true;
 

src/SharpCompress/Common/Volume.cs

@@ -11,10 +11,10 @@ public abstract partial class Volume : IVolume, IAsyncDisposable
     private readonly Stream _baseStream;
     private readonly Stream _actualStream;
 
-    internal Volume(Stream stream, ReaderOptions? readerOptions, int index = 0)
+    internal Volume(Stream stream, ReaderOptions readerOptions, int index = 0)
     {
         Index = index;
-        ReaderOptions = readerOptions ?? new ReaderOptions();
+        ReaderOptions = readerOptions;
         _baseStream = stream;
 
         // Only rewind if it's a buffered SharpCompressStream (not passthrough)

src/SharpCompress/Factories/TarFactory.cs

@@ -317,7 +317,7 @@ public async ValueTask<IAsyncArchive> OpenAsyncArchive(
     /// <inheritdoc/>
     public IReader OpenReader(Stream stream, ReaderOptions? options)
     {
-        options ??= new ReaderOptions();
+        options ??= ReaderOptions.ForExternalStream;
         var sharpCompressStream = new SharpCompressStream(stream);
         sharpCompressStream.StartRecording(TarWrapper.MaximumRewindBufferSize);
         foreach (var wrapper in TarWrapper.Wrappers)
@@ -350,7 +350,7 @@ public async ValueTask<IAsyncReader> OpenAsyncReader(
     )
     {
         cancellationToken.ThrowIfCancellationRequested();
-        options ??= new ReaderOptions();
+        options ??= ReaderOptions.ForExternalStream;
         var sharpCompressStream = new SharpCompressStream(stream);
         sharpCompressStream.StartRecording(TarWrapper.MaximumRewindBufferSize);
         foreach (var wrapper in TarWrapper.Wrappers)

src/SharpCompress/Readers/Ace/AceReader.Factory.cs

@@ -20,7 +20,7 @@ public partial class AceReader
     public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = null)
     {
         stream.NotNull(nameof(stream));
-        return new SingleVolumeAceReader(stream, readerOptions ?? new ReaderOptions());
+        return new SingleVolumeAceReader(stream, readerOptions ?? ReaderOptions.ForExternalStream);
     }
 
     /// <summary>
@@ -32,7 +32,7 @@ public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = n
     public static IReader OpenReader(IEnumerable<Stream> streams, ReaderOptions? options = null)
     {
         streams.NotNull(nameof(streams));
-        return new MultiVolumeAceReader(streams, options ?? new ReaderOptions());
+        return new MultiVolumeAceReader(streams, options ?? ReaderOptions.ForExternalStream);
     }
 
     public static ValueTask<IAsyncReader> OpenAsyncReader(
@@ -62,7 +62,7 @@ public static IAsyncReader OpenAsyncReader(
     )
     {
         streams.NotNull(nameof(streams));
-        return new MultiVolumeAceReader(streams, options ?? new ReaderOptions());
+        return new MultiVolumeAceReader(streams, options ?? ReaderOptions.ForExternalStream);
     }
 
     public static ValueTask<IAsyncReader> OpenAsyncReader(

src/SharpCompress/Readers/Arc/ArcReader.cs

@@ -25,7 +25,7 @@ private ArcReader(Stream stream, ReaderOptions options)
     public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = null)
     {
         stream.NotNull(nameof(stream));
-        return new ArcReader(stream, readerOptions ?? new ReaderOptions());
+        return new ArcReader(stream, readerOptions ?? ReaderOptions.ForExternalStream);
     }
 
     protected override IEnumerable<ArcEntry> GetEntries(Stream stream)

src/SharpCompress/Readers/Arj/ArjReader.cs

@@ -32,7 +32,7 @@ internal ArjReader(ReaderOptions options)
     public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = null)
     {
         stream.NotNull(nameof(stream));
-        return new SingleVolumeArjReader(stream, readerOptions ?? new ReaderOptions());
+        return new SingleVolumeArjReader(stream, readerOptions ?? ReaderOptions.ForExternalStream);
     }
 
     /// <summary>
@@ -44,7 +44,7 @@ public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = n
     public static IReader OpenReader(IEnumerable<Stream> streams, ReaderOptions? options = null)
     {
         streams.NotNull(nameof(streams));
-        return new MultiVolumeArjReader(streams, options ?? new ReaderOptions());
+        return new MultiVolumeArjReader(streams, options ?? ReaderOptions.ForExternalStream);
     }
 
     protected abstract void ValidateArchive(ArjVolume archive);

src/SharpCompress/Readers/GZip/GZipReader.Factory.cs

@@ -56,6 +56,6 @@ public static IReader OpenReader(FileInfo fileInfo, ReaderOptions? readerOptions
     public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = null)
     {
         stream.NotNull(nameof(stream));
-        return new GZipReader(stream, readerOptions ?? new ReaderOptions());
+        return new GZipReader(stream, readerOptions ?? ReaderOptions.ForExternalStream);
     }
 }

src/SharpCompress/Readers/Lzw/LzwReader.Factory.cs

@@ -56,6 +56,6 @@ public static IReader OpenReader(FileInfo fileInfo, ReaderOptions? readerOptions
     public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = null)
     {
         stream.NotNull(nameof(stream));
-        return new LzwReader(stream, readerOptions ?? new ReaderOptions());
+        return new LzwReader(stream, readerOptions ?? ReaderOptions.ForExternalStream);
     }
 }

src/SharpCompress/Readers/Rar/RarReader.cs

@@ -72,7 +72,7 @@ public static IReader OpenReader(IEnumerable<FileInfo> fileInfos, ReaderOptions?
     public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = null)
     {
         stream.NotNull(nameof(stream));
-        return new SingleVolumeRarReader(stream, readerOptions ?? new ReaderOptions());
+        return new SingleVolumeRarReader(stream, readerOptions ?? ReaderOptions.ForExternalStream);
     }
 
     /// <summary>
@@ -84,7 +84,7 @@ public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = n
     public static IReader OpenReader(IEnumerable<Stream> streams, ReaderOptions? options = null)
     {
         streams.NotNull(nameof(streams));
-        return new MultiVolumeRarReader(streams, options ?? new ReaderOptions());
+        return new MultiVolumeRarReader(streams, options ?? ReaderOptions.ForExternalStream);
     }
 
     protected override IEnumerable<RarReaderEntry> GetEntries(Stream stream)

src/SharpCompress/Readers/ReaderFactory.Async.cs

@@ -25,7 +25,11 @@ public static ValueTask<IAsyncReader> OpenAsyncReader(
     )
     {
         filePath.NotNullOrEmpty(nameof(filePath));
-        return OpenAsyncReader(new FileInfo(filePath), options, cancellationToken);
+        return OpenAsyncReader(
+            new FileInfo(filePath),
+            options ?? ReaderOptions.ForFilePath,
+            cancellationToken
+        );
     }
 
     /// <summary>

src/SharpCompress/Readers/ReaderFactory.cs

@@ -12,7 +12,7 @@ public static partial class ReaderFactory
     public static IReader OpenReader(string filePath, ReaderOptions? options = null)
     {
         filePath.NotNullOrEmpty(nameof(filePath));
-        return OpenReader(new FileInfo(filePath), options);
+        return OpenReader(new FileInfo(filePath), options ?? ReaderOptions.ForFilePath);
     }
 
     public static IReader OpenReader(FileInfo fileInfo, ReaderOptions? options = null)

src/SharpCompress/Readers/ReaderOptions.cs

@@ -151,35 +151,34 @@ public ReaderOptions() { }
     /// <summary>
     /// Gets ReaderOptions configured for caller-provided streams.
     /// </summary>
-    public static ReaderOptions ForExternalStream => new() { LeaveStreamOpen = true };
+    internal static ReaderOptions Default => new();
+
+    public static ReaderOptions ForExternalStream => Default.WithLeaveStreamOpen(true);
 
     /// <summary>
     /// Gets ReaderOptions configured for file-based overloads that open their own stream.
     /// </summary>
-    public static ReaderOptions ForFilePath => new() { LeaveStreamOpen = false };
+    public static ReaderOptions ForFilePath => Default;
 
     /// <summary>
     /// Creates ReaderOptions for reading encrypted archives.
     /// </summary>
     /// <param name="password">The password for encrypted archives.</param>
     public static ReaderOptions ForEncryptedArchive(string? password = null) =>
-        new ReaderOptions().WithPassword(password);
+        Default.WithPassword(password);
 
     /// <summary>
     /// Creates ReaderOptions for archives with custom character encoding.
     /// </summary>
     /// <param name="encoding">The encoding for archive entry names.</param>
     public static ReaderOptions ForEncoding(IArchiveEncoding encoding) =>
-        new ReaderOptions().WithArchiveEncoding(encoding);
+        Default.WithArchiveEncoding(encoding);
 
     /// <summary>
     /// Creates ReaderOptions for self-extracting archives that require header search.
     /// </summary>
     public static ReaderOptions ForSelfExtractingArchive(string? password = null) =>
-        new ReaderOptions()
-            .WithLookForHeader(true)
-            .WithPassword(password)
-            .WithRewindableBufferSize(1_048_576); // 1MB for SFX archives
+        Default.WithLookForHeader(true).WithPassword(password).WithRewindableBufferSize(1_048_576); // 1MB for SFX archives
 
     // Note: Parameterized constructors have been removed.
     // Use fluent With*() helpers or object initializers instead:

src/SharpCompress/Readers/Tar/TarReader.Factory.cs

@@ -89,7 +89,7 @@ public static async ValueTask<IAsyncReader> OpenAsyncReader(
     {
         cancellationToken.ThrowIfCancellationRequested();
         stream.NotNull(nameof(stream));
-        readerOptions ??= new ReaderOptions();
+        readerOptions ??= ReaderOptions.ForExternalStream;
         var sharpCompressStream = SharpCompressStream.Create(
             stream,
             bufferSize: Math.Max(
@@ -171,7 +171,7 @@ public static IReader OpenReader(FileInfo fileInfo, ReaderOptions? readerOptions
     public static IReader OpenReader(Stream stream, ReaderOptions? readerOptions = null)
     {
         stream.NotNull(nameof(stream));
-        readerOptions ??= new ReaderOptions();
+        readerOptions ??= ReaderOptions.ForExternalStream;
         var sharpCompressStream = SharpCompressStream.Create(
             stream,
             bufferSize: Math.Max(