Add comprehensive RAR5 async extraction tests#1205
Closed
Conversation
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
- Created Rar5AsyncExtractionTests with 12 tests that exercise Unpack5Async code path - Tests use AsyncOnlyStream to ensure async methods are called (not sync fallbacks) - Cover basic archives, solid archives, encrypted archives, and various extraction methods - Tests verify: * ExtractAllEntries for solid archives * Individual file extraction with WriteEntryToDirectoryAsync * OpenEntryStream for manual extraction * WriteToDirectory for full archive extraction * Encrypted files (both header+files and files only) * Special formats (Blake2 CRC, comments, uncompressed) * Skipping entries in solid archives - All tests passing on both net48 and net10.0 Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add RAR tests for Unpack5Async code path
Add comprehensive RAR5 async extraction tests
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async RAR5 extraction code path (
Unpack5Async) lacked dedicated test coverage to verify it executes correctly vs. falling back to sync methods.Changes
New test suite:
Rar5AsyncExtractionTestswith 12 tests covering:Async enforcement: All tests use
AsyncOnlyStreamwrapper that throws on synchronous Read operations, ensuring async code paths execute rather than sync fallbacksAll tests pass on net48 and net10.0.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.