Consolidate ArrayPool + ReadFully/ReadExact patterns into reusable utilities#1194
Draft
Consolidate ArrayPool + ReadFully/ReadExact patterns into reusable utilities#1194
Conversation
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consolidate ReadFully and ReadExact logic in codebase
Consolidate ArrayPool + ReadFully/ReadExact patterns into reusable utilities
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple files contained identical ArrayPool rent/return/try-finally patterns around stream reads. This consolidates them into helper methods.
Changes
Added utilities in
Utility.csandUtility.Async.cs:WithRentedBufferReadFully<T>()- Rents buffer, reads until full, executes callback, returns bufferTryWithRentedBufferReadFully<T>()- Same but returns false on EOF instead of throwingWithRentedBufferReadExact<T>()- Throws on partial readReplaced duplicate patterns in:
ArcFactory.cs- IsArchive signature checkSevenZipArchive.Factory.cs- Signature validationGZipArchive.Factory.cs- Header validationWinzipAesCryptoStream.cs- Auth bytes disposalBefore/After
Removes ~85 lines of boilerplate. All 1160 existing tests pass.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.