Fix dispose methods to always set _isDisposed and call base.Dispose() when LeaveOpen is true#1152
Merged
adamhathcock merged 3 commits intoadam/async-creationfrom Jan 22, 2026
Merged
Conversation
…ase.Dispose even when LeaveOpen is true Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
…stent property access Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on async creation cleanup and Dispose checks
Fix dispose methods to always set _isDisposed and call base.Dispose() when LeaveOpen is true
Jan 22, 2026
adamhathcock
approved these changes
Jan 22, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispose logic in
SharpCompressStreamreturned early whenLeaveOpenwas true without setting_isDisposedor callingbase.Dispose(), allowing subsequent dispose calls to re-execute disposal code.Changes:
Dispose()andDisposeAsync()to always set_isDisposedand call base disposal methodsLeaveOpencheck now only guards wrapped stream disposal and buffer cleanupBefore:
After:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.