Fix async test failures after xunit v3 upgrade#1137
Merged
adamhathcock merged 5 commits intoadam/upgrade-xunitfrom Jan 16, 2026
Merged
Fix async test failures after xunit v3 upgrade#1137adamhathcock merged 5 commits intoadam/upgrade-xunitfrom
adamhathcock merged 5 commits intoadam/upgrade-xunitfrom
Conversation
Merged
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
…kable streams) Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix tests to work with upgraded xunit v3
Fix async test failures after xunit v3 upgrade
Jan 16, 2026
adamhathcock
requested changes
Jan 16, 2026
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
adamhathcock
approved these changes
Jan 16, 2026
This was referenced Feb 11, 2026
This was referenced Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xunit v3 upgrade exposed that async tests were not properly awaiting async operations. Tests were passing
ValueTask<IAsyncReader>directly toawait usingstatements instead of awaiting the task first, andReaderFactory.OpenAsyncReaderwas calling synchronousIsArchivemethods during format detection.Changes
ReaderFactory.OpenAsyncReaderproperly async: Changed return type toValueTask<IAsyncReader>and replaced synchronousIsArchive()calls withIsArchiveAsync()during format detectionawaitbeforeReaderFactory.OpenAsyncReader()in all async test methodsAsyncOnlyStreamin Archive async tests: Archive async tests continue to useAsyncOnlyStreamto validate that archive operations properly handle async-only streams, exposing areas where synchronous I/O is still used in async code pathsExample
Before:
After:
Known Limitations
AsyncOnlyStreamto fail. These tests intentionally expose the need for async archive opening support.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.