Consolidate NETFRAMEWORK/NETSTANDARD compile flags into LEGACY_DOTNET by Copilot · Pull Request #1135 · adamhathcock/sharpcompress

Copilot · 2026-01-15T17:50:54Z

Consolidate compile flags for NETFRAMEWORK and NETSTANDARD

Summary of Changes

This PR consolidates scattered NETFRAMEWORK and NETSTANDARD2_0 compile flags into a single, clearer LEGACY_DOTNET constant.

What Changed

Added LEGACY_DOTNET compile constant in SharpCompress.csproj
- Defined for net48 and netstandard20 targets
- Provides clear semantic meaning: code for legacy .NET platforms vs. modern .NET
Replaced 41 occurrences across 25 files:
- #if !NETFRAMEWORK && !NETSTANDARD2_0 → #if !LEGACY_DOTNET
- #if NETFRAMEWORK || NETSTANDARD2_0 → #if LEGACY_DOTNET
- #if !NETSTANDARD2_0 && !NETSTANDARD2_1 && !NETFRAMEWORK → #if !LEGACY_DOTNET
- #if NETFRAMEWORK || NETSTANDARD → #if LEGACY_DOTNET
- #if NETCOREAPP2_1_OR_GREATER || NETSTANDARD2_1_OR_GREATER → #if !LEGACY_DOTNET
Additional simplifications:
- Removed obsolete NETCF (NET Compact Framework) flag - not a supported target
- Fixed typo: NET60_OR_GREATER → NET6_0_OR_GREATER
- Changed NET6_0_OR_GREATER → NET8_0_OR_GREATER (5 occurrences in 3 files)
- Total: 6 additional simplifications

Benefits

✨ Clearer intent: LEGACY_DOTNET communicates purpose better than framework checks
🔧 Easier maintenance: Single source of truth for legacy vs. modern .NET
📉 Reduced duplication: No need to repeat complex multi-framework conditions
🐛 Fewer errors: Single constant reduces typos and inconsistent checks
🎯 Better targeting: NET8_0_OR_GREATER aligns with actual project targets (net8.0, net10.0)

Verification ✅

Original prompt

This section details on the original issue you should resolve

<issue_title>Consolidate compile flags</issue_title>
<issue_description>NETFRAMEWORK and NETSTANDARD should be combined into a single compile flags to be used in code and replaced.

See if there are opportunities for other simplification</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Consolidate compile flags #1134

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

… NETCOREAPP2_1 pattern Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

adamhathcock · 2026-01-15T18:25:16Z

@copilot make the dotnet 6 or greater flag be dotnet 8 or greater

Copilot

Pull request overview

This PR consolidates scattered compile-time conditional directives by introducing a unified LEGACY_DOTNET constant to distinguish between legacy frameworks (net48, netstandard20) and modern .NET (net8.0, net10.0). This refactoring improves code maintainability by replacing 45+ occurrences of complex flag combinations with a single, clearly-named constant.

Changes:

Added LEGACY_DOTNET compile constant in the project file for net48 and netstandard20 targets
Replaced complex combinations of NETFRAMEWORK/NETSTANDARD flags throughout the codebase with LEGACY_DOTNET or !LEGACY_DOTNET
Removed obsolete NETCF (NET Compact Framework) references
Fixed typo in compile constant: NET60_OR_GREATER → NET6_0_OR_GREATER
Updated Microsoft.NET.ILLink.Tasks package from 10.0.0 to 10.0.1

Reviewed changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/SharpCompress/SharpCompress.csproj	Defines LEGACY_DOTNET constant for net48 and netstandard20 targets
src/SharpCompress/packages.lock.json	Updates ILLink.Tasks package version
src/SharpCompress/Utility.cs	Fixes NET6_0_OR_GREATER typo
src/SharpCompress/Readers/AbstractReader.cs	Replaces NETFRAMEWORK\|\|NETSTANDARD2_0 with LEGACY_DOTNET
src/SharpCompress/Polyfills/StringExtensions.cs	Replaces NETFRAMEWORK\|\|NETSTANDARD2_0 with LEGACY_DOTNET
src/SharpCompress/NotNullExtensions.cs	Replaces NETFRAMEWORK\|\|NETSTANDARD with LEGACY_DOTNET
src/SharpCompress/IO/SourceStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/IO/SharpCompressStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/IO/ReadOnlySubStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/IO/ProgressReportingStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/IO/BufferedSubStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Crypto/Crc32Stream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/ZStandard/DecompressionStream.cs	Replaces !NETSTANDARD2_0&&!NETFRAMEWORK with !LEGACY_DOTNET
src/SharpCompress/Compressors/ZStandard/CompressionStream.cs	Replaces !NETSTANDARD2_0&&!NETFRAMEWORK with !LEGACY_DOTNET
src/SharpCompress/Compressors/Rar/RarStream.cs	Replaces NETCOREAPP2_1_OR_GREATER\|\|NETSTANDARD2_1_OR_GREATER with !LEGACY_DOTNET
src/SharpCompress/Compressors/Rar/RarCrcStream.cs	Replaces NETCOREAPP2_1_OR_GREATER\|\|NETSTANDARD2_1_OR_GREATER with !LEGACY_DOTNET
src/SharpCompress/Compressors/Rar/RarBLAKE2spStream.cs	Replaces NETCOREAPP2_1_OR_GREATER\|\|NETSTANDARD2_1_OR_GREATER with !LEGACY_DOTNET
src/SharpCompress/Compressors/Rar/MultiVolumeReadOnlyStream.cs	Replaces NETCOREAPP2_1_OR_GREATER\|\|NETSTANDARD2_1_OR_GREATER with !LEGACY_DOTNET
src/SharpCompress/Compressors/LZMA/LzmaStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/LZMA/LzmaDecoder.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/LZMA/LZipStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/Deflate64/Deflate64Stream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/Deflate/ZlibStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/Deflate/ZlibConstants.cs	Removes obsolete NETCF conditional compilation and updates comment
src/SharpCompress/Compressors/Deflate/ZlibBaseStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/Deflate/GZipStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/Deflate/DeflateStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Compressors/BZip2/BZip2Stream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Common/Zip/WinzipAesEncryptionData.cs	Replaces NETFRAMEWORK\|\|NETSTANDARD2_0 with LEGACY_DOTNET
src/SharpCompress/Common/Tar/TarReadOnlySubStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Common/EntryStream.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs	Replaces !NETFRAMEWORK&&!NETSTANDARD2_0 with !LEGACY_DOTNET
src/SharpCompress/Algorithms/Adler32.cs	Replaces !NETSTANDARD2_0&&!NETSTANDARD2_1&&!NETFRAMEWORK with !LEGACY_DOTNET

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

Copilot · 2026-01-15T18:31:21Z

@copilot make the dotnet 6 or greater flag be dotnet 8 or greater

Changed all 5 occurrences of NET6_0_OR_GREATER to NET8_0_OR_GREATER in 3 files (Utility.cs, AsyncBinaryReader.cs, UnsafeHelper.cs). All targets build successfully and 984 tests pass. Commit: d2cb792

Initial plan

405dbb3

Copilot AI assigned Copilot and adamhathcock Jan 15, 2026

Copilot started work on behalf of adamhathcock January 15, 2026 17:51 View session

Copilot AI and others added 3 commits January 15, 2026 17:55

Initial analysis: Planning compile flags consolidation

cab3e7d

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

Replace NETFRAMEWORK and NETSTANDARD2_0 with LEGACY_DOTNET compile flag

a5300f3

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

Additional simplifications: Remove NETCF, fix NET60 typo, consolidate…

52fef49

… NETCOREAPP2_1 pattern Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Consolidate NETFRAMEWORK and NETSTANDARD compile flags~~ Consolidate NETFRAMEWORK/NETSTANDARD compile flags into LEGACY_DOTNET Jan 15, 2026

Copilot AI requested a review from adamhathcock January 15, 2026 18:15

Copilot finished work on behalf of adamhathcock January 15, 2026 18:15

adamhathcock approved these changes Jan 15, 2026

View reviewed changes

adamhathcock marked this pull request as ready for review January 15, 2026 18:24

Copilot AI review requested due to automatic review settings January 15, 2026 18:24

Copilot started reviewing on behalf of adamhathcock January 15, 2026 18:24 View session

Copilot started work on behalf of adamhathcock January 15, 2026 18:25 View session

adamhathcock enabled auto-merge January 15, 2026 18:26

adamhathcock disabled auto-merge January 15, 2026 18:26

Copilot AI reviewed Jan 15, 2026

View reviewed changes

Change NET6_0_OR_GREATER to NET8_0_OR_GREATER

d2cb792

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>

Copilot AI requested a review from adamhathcock January 15, 2026 18:32

Copilot finished work on behalf of adamhathcock January 15, 2026 18:32

adamhathcock approved these changes Jan 15, 2026

View reviewed changes

adamhathcock enabled auto-merge January 15, 2026 18:42

adamhathcock merged commit f5d83c0 into master Jan 15, 2026
5 checks passed

adamhathcock deleted the copilot/consolidate-compile-flags branch January 15, 2026 18:47

This was referenced Feb 11, 2026

Bump SharpCompress from 0.44.1 to 0.45.1 AssetRipper/Tpk#124

Closed

Bump SharpCompress from 0.42.1 to 0.45.1 Kiryuumaru/AbsolutePathHelpers#139

Closed

Bump SharpCompress from 0.44.1 to 0.46.0 AssetRipper/Tpk#125

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Consolidate NETFRAMEWORK/NETSTANDARD compile flags into LEGACY_DOTNET#1135

Consolidate NETFRAMEWORK/NETSTANDARD compile flags into LEGACY_DOTNET#1135
adamhathcock merged 5 commits intomasterfrom
copilot/consolidate-compile-flags

Copilot AI commented Jan 15, 2026 •

edited

Loading

Uh oh!

adamhathcock commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Copilot AI commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Consolidate compile flags for NETFRAMEWORK and NETSTANDARD

Summary of Changes

What Changed

Benefits

Verification ✅

Comments on the Issue (you are @copilot in this section)

Uh oh!

adamhathcock commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Jan 15, 2026 •

edited

Loading