Fix async test method naming in ZipArchiveAsyncTests#1127
Merged
adamhathcock merged 2 commits intoadam/asyncfrom Jan 12, 2026
Merged
Fix async test method naming in ZipArchiveAsyncTests#1127adamhathcock merged 2 commits intoadam/asyncfrom
adamhathcock merged 2 commits intoadam/asyncfrom
Conversation
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on async improvements for ZipReader and ZipWriter
Fix async test method naming in ZipArchiveAsyncTests
Jan 12, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two test methods in
ZipArchiveAsyncTests.cswere named with_Syncsuffix despite being async methods (returningValueTaskand usingawait).Changes
Zip_Random_Write_Remove_Sync→Zip_Random_Write_Remove_AsyncZip_Random_Write_Add_Sync→Zip_Random_Write_Add_AsyncThis aligns with the naming convention used throughout the test file where async test methods use the
_Asyncsuffix.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.