Fix typo in TestBase.cs comment#1126
Merged
adamhathcock merged 2 commits intoadam/asyncfrom Jan 12, 2026
Merged
Conversation
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on async improvements for ZipReader and ZipWriter
Fix typo in TestBase.cs comment
Jan 12, 2026
adamhathcock
approved these changes
Jan 12, 2026
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #1121 - corrects spelling error in comment explaining async disposal pattern.
Changes
tests/SharpCompress.Test/TestBase.csline 58: "akways" → "always"The comment now correctly reads:
//always use async dispose since we have I/O and sync Dispose doesn't wait when using xunit💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.