Skip to content

[WIP] Update ZipReader and ZipWriter based on review feedback#1125

Merged
adamhathcock merged 2 commits intoadam/asyncfrom
copilot/sub-pr-1121-again
Jan 12, 2026
Merged

[WIP] Update ZipReader and ZipWriter based on review feedback#1125
adamhathcock merged 2 commits intoadam/asyncfrom
copilot/sub-pr-1121-again

Conversation

Copy link
Contributor

Copilot AI commented Jan 12, 2026

  • Analyze the feedback about inconsistent usage of File.Create vs File.OpenWrite
  • Identify the issue in TarReaderAsyncTests.cs at line 95
  • Change File.Create back to File.OpenWrite for consistency with sync version and other async tests
  • Verify the change with tests

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…stency

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
@adamhathcock adamhathcock marked this pull request as ready for review January 12, 2026 12:09
@adamhathcock adamhathcock merged commit c3ffcf4 into adam/async Jan 12, 2026
@adamhathcock adamhathcock deleted the copilot/sub-pr-1121-again branch January 12, 2026 12:09
Copilot AI requested a review from adamhathcock January 12, 2026 12:10
Copilot stopped work on behalf of adamhathcock due to an error January 12, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants