Fix async test method naming inconsistency in ZipArchiveAsyncTests#1124
Merged
adamhathcock merged 2 commits intoadam/asyncfrom Jan 12, 2026
Merged
Fix async test method naming inconsistency in ZipArchiveAsyncTests#1124adamhathcock merged 2 commits intoadam/asyncfrom
adamhathcock merged 2 commits intoadam/asyncfrom
Conversation
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
adamhathcock
approved these changes
Jan 12, 2026
Copilot
AI
changed the title
[WIP] Address feedback on async implementation for ZipReader and ZipWriter
Fix async test method naming inconsistency in ZipArchiveAsyncTests
Jan 12, 2026
Copilot stopped work on behalf of
adamhathcock due to an error
January 12, 2026 12:09
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two async test methods in
ZipArchiveAsyncTests.cshad "Sync" suffixes despite being async methods usingawait.Changes
Zip_Random_Write_Remove_Sync→Zip_Random_Write_Remove_AsyncZip_Random_Write_Add_Sync→Zip_Random_Write_Add_AsyncBoth methods use
async ValueTaskandawait archive.SaveToAsync(), so the "Async" suffix correctly reflects their implementation.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.