Skip to content

Comments

Add more documentation#1123

Merged
adamhathcock merged 5 commits intomasterfrom
adam/add-more-docs
Jan 11, 2026
Merged

Add more documentation#1123
adamhathcock merged 5 commits intomasterfrom
adam/add-more-docs

Conversation

@adamhathcock
Copy link
Owner

@adamhathcock adamhathcock commented Jan 8, 2026

This pull request primarily updates documentation to improve clarity and maintain consistency after moving usage documentation into the docs directory. It also adds an important guideline for agents and updates links to reflect the new documentation structure.

Documentation structure and link updates:

  • Updated all references to USAGE.md and FORMATS.md in README.md and AGENTS.md to point to their new locations under the docs/ directory. [1] [2] [3]
  • Renamed USAGE.md to docs/USAGE.md and updated its headings for clarity, including marking async/await support as "Beta" and simplifying the "Stream Rules" section heading. [1] [2]

Agent guidelines:

  • Added a new rule in AGENTS.md stating that agents should never commit to git, but only stage files, leaving commits to the user unless explicitly requested.

Copilot AI review requested due to automatic review settings January 8, 2026 15:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request restructures documentation by moving usage documentation into the docs directory and adding comprehensive new documentation files. The changes primarily focus on improving documentation organization and adding extensive guides for performance, encoding, architecture, and API usage.

  • Moved USAGE.md to docs/USAGE.md and updated all internal references
  • Added six new comprehensive documentation files (PERFORMANCE.md, FORMATS.md, ENCODING.md, ARCHITECTURE.md, API.md, OLD_CHANGELOG.md)
  • Updated links in README.md and AGENTS.md to point to the new documentation locations
  • Added "Beta" label to async/await section and simplified "Stream Rules" title

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
docs/USAGE.md Labeled async/await support as "Beta" and simplified Stream Rules section title
docs/PERFORMANCE.md New comprehensive performance optimization guide with API selection, buffering, and troubleshooting advice
docs/OLD_CHANGELOG.md New file containing historical version logs from 0.10 through 0.18
docs/FORMATS.md New file documenting supported archive formats, compression methods, and format-specific notes
docs/ENCODING.md New extensive guide on character encoding handling for international filenames
docs/ARCHITECTURE.md New detailed architecture documentation for contributors including design patterns and internal structure
docs/API.md New quick reference guide for commonly used SharpCompress APIs with code examples
README.md Updated documentation links to point to docs/USAGE.md and docs/FORMATS.md
AGENTS.md Updated FORMATS.md reference to docs/FORMATS.md

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


## Related Documentation

- [PERFORMANCE.md](USAGE.md) - Usage examples with performance considerations
Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to "PERFORMANCE.md" should be "USAGE.md" since this line appears in PERFORMANCE.md and is trying to reference USAGE.md for usage examples.

Suggested change
- [PERFORMANCE.md](USAGE.md) - Usage examples with performance considerations
- [USAGE.md](USAGE.md) - Usage examples with performance considerations

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 8, 2026 15:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Remove CONTRIBUTING.md reference from ARCHITECTURE.md
- Remove ERRORS.md reference from API.md
- Remove TROUBLESHOOTING.md reference from ENCODING.md
- Remove TROUBLESHOOTING.md reference from PERFORMANCE.md

All markdown files now reference only existing documentation.
Agents should stage files and leave committing to the user. Only create
commits when the user explicitly requests them.
Copilot AI review requested due to automatic review settings January 8, 2026 15:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

### Object Pooling for Repeated Operations

```csharp
// For very high-throughput scenarios, consider pooling
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems wrong


## Memory Efficiency

### Reducing Allocations
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems wrong

| Download streams | Reader | Async extraction while downloading |

### 2. Batch Operations

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems wrong

}
```

### 3. Use Appropriate Compression
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary


## Buffer Sizing

### Understanding Buffers
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review


## Compression Level Trade-offs

### Deflate/GZip Levels
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant