Skip to content

remove old release#1098

Merged
adamhathcock merged 5 commits intomasterfrom
adam/remove-old-release
Jan 3, 2026
Merged

remove old release#1098
adamhathcock merged 5 commits intomasterfrom
adam/remove-old-release

Conversation

@adamhathcock
Copy link
Owner

This pull request removes the existing .github/workflows/dotnetcore.yml GitHub Actions workflow and updates the solution file to reference a new workflow file, .github/workflows/nuget-release.yml, instead. This likely reflects a change in the project's CI/CD process, possibly consolidating or renaming workflows for clarity or updated release processes.

Continuous Integration / Workflow Updates:

  • Removed the dotnetcore.yml workflow, which previously handled builds and artifact uploads for multiple operating systems.
  • Updated the SharpCompress.sln solution file to reference the new nuget-release.yml workflow instead of the removed dotnetcore.yml.

Copilot AI review requested due to automatic review settings January 3, 2026 13:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes an outdated GitHub Actions workflow and updates the solution file to reference the new workflow. The changes streamline the CI/CD configuration by replacing the basic dotnetcore.yml workflow with the more comprehensive nuget-release.yml workflow that already exists in the repository.

  • Removes the legacy dotnetcore.yml workflow file that provided basic build and artifact upload functionality
  • Updates the solution file reference to point to the new nuget-release.yml workflow

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/dotnetcore.yml Complete removal of the legacy workflow file
SharpCompress.sln Updated workflow reference from dotnetcore.yml to nuget-release.yml

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamhathcock
Copy link
Owner Author

@copilot nuget-release.yml should run for pull requests against master and release but never publish. Only when something is merged or tagged

Copy link
Contributor

Copilot AI commented Jan 3, 2026

@adamhathcock I've opened a new pull request, #1099, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits January 3, 2026 14:15
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Configure nuget-release workflow to validate PRs without publishing
@adamhathcock adamhathcock merged commit 2327679 into master Jan 3, 2026
5 checks passed
@adamhathcock adamhathcock deleted the adam/remove-old-release branch January 3, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments