Skip to content

Comments

Add back System.Buffers and System.Memory to central package management#1093

Merged
adamhathcock merged 2 commits intoadam/update-deps2from
copilot/sub-pr-1091
Dec 30, 2025
Merged

Add back System.Buffers and System.Memory to central package management#1093
adamhathcock merged 2 commits intoadam/update-deps2from
copilot/sub-pr-1091

Conversation

Copy link
Contributor

Copilot AI commented Dec 30, 2025

The dependency update removed System.Buffers and System.Memory from Directory.Packages.props, but these packages are still referenced by SharpCompress.csproj for .NET Framework 4.8 targets, causing build failures.

Changes

  • Added System.Buffers 4.6.1 to Directory.Packages.props
  • Added System.Memory 4.6.3 to Directory.Packages.props

Versions were set to satisfy transitive dependency constraints from System.Text.Encoding.CodePages 10.0.0, which requires System.Memory >= 4.6.3 and System.Buffers >= 4.6.1.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
Copilot AI changed the title [WIP] Update NuGet package dependencies and tools Add back System.Buffers and System.Memory to central package management Dec 30, 2025
Copilot AI requested a review from adamhathcock December 30, 2025 11:31
@adamhathcock adamhathcock marked this pull request as ready for review December 30, 2025 11:31
@adamhathcock adamhathcock merged commit 32d5b61 into adam/update-deps2 Dec 30, 2025
2 checks passed
@adamhathcock adamhathcock deleted the copilot/sub-pr-1091 branch December 30, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants