Fix: Should not throw on ARJ detection#1067
Merged
adamhathcock merged 3 commits intoreleasefrom Dec 8, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #1064 where ArjFactory.IsArchive would throw exceptions when attempting to detect non-ARJ files, rather than returning false as expected. The fix wraps the ARJ header detection logic in a try-catch block to handle invalid data gracefully.
- Adds exception handling to
ArjFactory.IsArchiveto catch exceptions during header parsing - Adds two test cases to verify the fix: one for non-archive files and one for valid archives
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/SharpCompress/Factories/ArjFactory.cs | Adds try-catch block around ARJ header reading to return false instead of throwing on invalid data |
| tests/SharpCompress.Test/ArchiveTests.cs | Adds regression tests for IsArchive method behavior with both invalid and valid archive files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Dec 22, 2025
This was referenced Jan 5, 2026
This was referenced Jan 5, 2026
This was referenced Jan 19, 2026
This was referenced Jan 26, 2026
This was referenced Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #1066
Fixes #1064