Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds asynchronous test coverage for Arc reader functionality, addressing issue #992. The changes include creating a new ArcReaderAsyncTests class and updating the test infrastructure to support nullable compression type parameters in async tests.
- New
ArcReaderAsyncTestsclass with three async test methods for different Arc compression types - Updated
ReaderTests.csto make theexpectedCompressionparameter nullable in async methods - Converted a synchronous reader call to async in
WriterTests.cs - Cleaned up unused imports in
ArcReaderTests.cs
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/SharpCompress.Test/Arc/ArcReaderAsyncTests.cs | New test class with async tests for Arc uncompressed, squeezed, and crunched archives |
| tests/SharpCompress.Test/ReaderTests.cs | Modified async read methods to support nullable compression type parameter with conditional assertion logic |
| tests/SharpCompress.Test/WriterTests.cs | Updated to use async API with cancellation token support |
| tests/SharpCompress.Test/Arc/ArcReaderTests.cs | Removed unused using statements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #992