Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharpCompress 0.34.0 does not have a strong name. #764

Closed
AptiviCEO opened this issue Sep 18, 2023 · 7 comments · Fixed by #780
Closed

SharpCompress 0.34.0 does not have a strong name. #764

AptiviCEO opened this issue Sep 18, 2023 · 7 comments · Fixed by #780

Comments

@AptiviCEO
Copy link

Hello,

First of all, thank you for your efforts at making this library.

As of the recent update that was released an hour long, SharpCompress 0.34.0 wasn't signed with a strong name, which causes every library that are signed with a strong key to emit warnings that say:

CS8002: Referenced assembly 'SharpCompress, Version=0.34.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name.

SharpCompress 0.33.0 didn't emit this warning because it was signed. Also, this signing key change wasn't listed in the changelogs.

What is the cause of the lack of signing? I would like this to be fixed.

Thanks!
AptiviCEO added a commit to Aptivi/NitrocidKS that referenced this issue Sep 18, 2023
@AptiviCEO
upd - Updated two libraries
fc56f5c 
We've updated two libraries.

---

Updated the following libraries to their respective versions:
  - SharpCompress: 0.34.0
  - VisualCard: 0.7.0

Unfortunately, SharpCompress was no longer signed with a strong name. The authors have been informed.

Refer to adamhathcock/sharpcompress#764 for more info.

---

Type: upd
Breaking: False
Doc Required: False
Part: 1/1
@adamhathcock
Copy link
Owner

Must be the new dependency for zstd that prevents it as nothing else has been done to stop strong naming

@AptiviCEO
Copy link
Author

OK, thanks. However, it looks like that the zstd port is strong named in the project file:

https://github.com/oleg-st/ZstdSharp/blob/master/src/ZstdSharp/ZstdSharp.csproj

@caesay
Copy link
Contributor

caesay commented Nov 4, 2023

For now, seems 0.33.0 is the last release that can be used on the full framework because of this issue. 34.0 and 34.1 both fail due to strong name issues. This is not a problem in dotnet (core) because strong names are not checked.

AlexVallat referenced this issue Nov 9, 2023
@Nanook
ZStandard support added to zip/zipx (WinZip) and 7zip (mcmilk 7zip)
92df1ec
@AlexVallat
Copy link

Looks like <SignAssembly> was changed to false in SharpCompress.csproj, but was this deliberate for some reason?

@caesay caesay mentioned this issue Nov 14, 2023
Merged
@caesay
Copy link
Contributor

caesay commented Nov 14, 2023

I've opened #780 to address this.

@adamhathcock
Copy link
Owner

Merged that and deployed https://www.nuget.org/packages/SharpCompress/0.34.2 to fix by @caesay

@AptiviCEO
Copy link
Author

I updated this library and I no longer have this issue. Thanks @adamhathcock and @caesay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert change disabling strong name signing in 92df1ec caesay/sharpcompress
4 participants
@adamhathcock @AlexVallat @caesay @AptiviCEO