ci: run CI for pull requests targeting the SCCM integration branch - #421
Conversation
The CI workflow triggers only on `main`, but the entire SCCM program stacks on `codex/parser-family-skeleton`. Seven open pull requests (#391, #392, #394, #404, #405, #407, #420) therefore run none of the six jobs -- no cargo check/test, no clippy, no MSRV check, no tsc, no Playwright E2E, and no platform builds -- while still reporting as mergeable. GitHub gives no signal for this: a pull request whose base branch is absent from the trigger list is not "pending" or "skipped", it simply has no checks, which is easy to misread as a passing PR with light gating. Add the integration branch to both triggers so lane PRs are gated before they land on it, and so the branch itself is checked after each merge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning
|
| Layer / File(s) | Summary |
|---|---|
Workflow branch targets .github/workflows/cmtrace-ci.yml |
The workflow retains main and adds codex/parser-family-skeleton to push and pull-request branch filters. Comments document the integration-branch requirement. |
Estimated code review effort: 1 (Trivial) | ~2 minutes
Suggested reviewers: copilot
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
| Check name | Status | Explanation |
|---|---|---|
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes enabling CI for pull requests targeting the SCCM integration branch, which is a primary part of the workflow change. |
Comment @coderabbitai help to get the list of available commands.
There was a problem hiding this comment.
Pull request overview
Updates the main CI workflow trigger so that PRs targeting the long-lived SCCM integration branch (codex/parser-family-skeleton) run the full CI job suite, and pushes to that branch are also verified.
Changes:
- Add
codex/parser-family-skeletontoon.push.branches. - Add
codex/parser-family-skeletontoon.pull_request.branches(with an explanatory comment).
Problem
.github/workflows/cmtrace-ci.ymltriggers only onmain:The entire SCCM program stacks on
codex/parser-family-skeleton, an integration branch currently 276 commits ahead ofmain. Every open SCCM lane PR targets it:None of them run any of the workflow's six jobs:
check(cargo check/test/clippy),msrv,frontend(tsc --noEmit),e2e(Playwright),windows-esp, orbuild(macOS-arm64 / Windows-x64 / Linux-x64).What makes this easy to miss is that GitHub reports nothing at all. A PR whose base branch is absent from the trigger list does not show pending or skipped checks -- it shows only the CodeRabbit and labeler entries, which reads like a PR with light gating rather than one with no gating. All seven currently report as mergeable.
Change
Add
codex/parser-family-skeletonto both triggers, so lane PRs are gated before they land on the integration branch and the branch itself is verified after each merge.Tradeoff
Adding the branch to the
pushtrigger means full CI, including the three platform builds, on every merge into the integration branch. That is real CI time, and it is the point: 276 commits have accumulated there without a single automated check.Verification
{push: [main, codex/parser-family-skeleton], pull_request: [main, codex/parser-family-skeleton]}git diff --checkclean; the diff touches only theon:block🤖 Generated with Claude Code
Summary by CodeRabbit
Part of #317