Skip to content

ci: run CI for pull requests targeting the SCCM integration branch - #421

Merged
adamgell merged 1 commit into
mainfrom
ci/gate-integration-branch
Aug 1, 2026
Merged

ci: run CI for pull requests targeting the SCCM integration branch#421
adamgell merged 1 commit into
mainfrom
ci/gate-integration-branch

Conversation

@adamgell

@adamgell adamgell commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Problem

.github/workflows/cmtrace-ci.yml triggers only on main:

on:
  push:
    branches: [main]
  pull_request:
    branches: [main]

The entire SCCM program stacks on codex/parser-family-skeleton, an integration branch currently 276 commits ahead of main. Every open SCCM lane PR targets it:

PR Lane
#391 client policy transactions
#392 client health and location evidence
#394 pure client intake coverage
#404 spine hardening
#405 site core status evidence
#407 client deployment transactions
#420 spine overlap validation

None of them run any of the workflow's six jobs: check (cargo check/test/clippy), msrv, frontend (tsc --noEmit), e2e (Playwright), windows-esp, or build (macOS-arm64 / Windows-x64 / Linux-x64).

What makes this easy to miss is that GitHub reports nothing at all. A PR whose base branch is absent from the trigger list does not show pending or skipped checks -- it shows only the CodeRabbit and labeler entries, which reads like a PR with light gating rather than one with no gating. All seven currently report as mergeable.

Change

Add codex/parser-family-skeleton to both triggers, so lane PRs are gated before they land on the integration branch and the branch itself is verified after each merge.

Tradeoff

Adding the branch to the push trigger means full CI, including the three platform builds, on every merge into the integration branch. That is real CI time, and it is the point: 276 commits have accumulated there without a single automated check.

Verification

  • YAML parses; triggers resolve to {push: [main, codex/parser-family-skeleton], pull_request: [main, codex/parser-family-skeleton]}
  • All six job definitions unchanged
  • git diff --check clean; the diff touches only the on: block

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated continuous integration workflows to run for pushes and pull requests targeting both supported branches.

Part of #317

The CI workflow triggers only on `main`, but the entire SCCM program stacks
on `codex/parser-family-skeleton`. Seven open pull requests (#391, #392,
#394, #404, #405, #407, #420) therefore run none of the six jobs -- no
cargo check/test, no clippy, no MSRV check, no tsc, no Playwright E2E, and
no platform builds -- while still reporting as mergeable.

GitHub gives no signal for this: a pull request whose base branch is absent
from the trigger list is not "pending" or "skipped", it simply has no
checks, which is easy to misread as a passing PR with light gating.

Add the integration branch to both triggers so lane PRs are gated before
they land on it, and so the branch itself is checked after each merge.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings August 1, 2026 16:54
@github-actions github-actions Bot added enhancement New feature or request parser Log parser related sccm SCCM/ConfigMgr related labels Aug 1, 2026
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

.coderabbit.yaml has a parsing error

The CodeRabbit configuration file in this repository has a parsing error and default settings were used instead. Please fix the error(s) in the configuration file. You can initialize chat with CodeRabbit to get help with the configuration file.

💥 Parsing errors (1)
Validation error: Too big: expected string to have <=250 characters at "tone_instructions"
⚙️ Configuration instructions
  • Please see the configuration documentation for more information.
  • You can also validate your configuration using the online YAML validator.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
📝 Walkthrough

Walkthrough

The CI workflow now runs for pushes and pull requests targeting main and codex/parser-family-skeleton. Comments document the integration-branch requirement.

Changes

CI branch filters

Layer / File(s) Summary
Workflow branch targets
.github/workflows/cmtrace-ci.yml
The workflow retains main and adds codex/parser-family-skeleton to push and pull-request branch filters. Comments document the integration-branch requirement.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes enabling CI for pull requests targeting the SCCM integration branch, which is a primary part of the workflow change.

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the main CI workflow trigger so that PRs targeting the long-lived SCCM integration branch (codex/parser-family-skeleton) run the full CI job suite, and pushes to that branch are also verified.

Changes:

  • Add codex/parser-family-skeleton to on.push.branches.
  • Add codex/parser-family-skeleton to on.pull_request.branches (with an explanatory comment).

@adamgell
adamgell merged commit 649168e into main Aug 1, 2026
18 checks passed
adamgell added a commit that referenced this pull request Aug 1, 2026
Port the trigger-only change from #421 onto the SCCM integration branch.\n\nRefs #317.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request parser Log parser related sccm SCCM/ConfigMgr related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants