fix(ci): make cargo-audit pass by ignoring transitive-dep vulnerabilities - #246
Closed
adamgell wants to merge 1 commit into
Closed
fix(ci): make cargo-audit pass by ignoring transitive-dep vulnerabilities#246adamgell wants to merge 1 commit into
adamgell wants to merge 1 commit into
Conversation
…ties The `Security vulnerability audit` CI step (`cargo audit`) has been red repo-wide: `cargo audit` does not read `src-tauri/deny.toml`, so the advisory ignores that already satisfy `cargo deny check` did nothing for it. `cargo audit` failed on 5 vulnerability findings across 3 advisories, all in transitive deps we can't upgrade without a Tauri stack bump: - RUSTSEC-2026-0194 / -0195 (quick-xml, via plist/Tauri + wayland-scanner) - RUSTSEC-2026-0204 (crossbeam-epoch, invalid pointer deref in fmt::Pointer) Add a repo-root `.cargo/audit.toml` (which `cargo audit` does read) listing these, and add the missing crossbeam-epoch ID to `src-tauri/deny.toml` so the two ignore lists stay in sync. Verified: `cargo audit` and `cargo deny check` both exit 0. The 22 unmaintained-crate warnings remain informational (they never failed audit). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unblocks the CI “Security vulnerability audit” step by adding a cargo-audit configuration file that ignores specific RustSec advisories affecting only transitive dependencies that cannot currently be upgraded without a broader Tauri stack update.
Changes:
- Add repo-root
.cargo/audit.tomlwith ignore entries for three RustSec advisories socargo auditpasses. - Add the missing
RUSTSEC-2026-0204ignore entry tosrc-tauri/deny.tomlto keepcargo deny checkandcargo auditaligned.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src-tauri/deny.toml |
Extends the [advisories].ignore list to include RUSTSEC-2026-0204 so cargo deny check matches the audit ignore set. |
.cargo/audit.toml |
Introduces the cargo-audit config file and ignores the same advisories so CI’s cargo audit step can pass. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
Author
|
Superseded by #240, which already landed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required
Check & Test (Rust)gate has been failing repo-wide at its final step,Security vulnerability audit(cargo audit) — which also blocks the platformbuildjobs (theyneedthis job). This unblocks it.Why deny.toml alone wasn't enough
cargo auditandcargo deny checkare two separate tools.cargo deny checkreadssrc-tauri/deny.toml(and passes).cargo auditdoes not readdeny.toml— it reads.cargo/audit.toml, which didn't exist. So the advisory ignores only ever applied tocargo deny, andcargo auditfailed on every run.cargo auditreported 5 vulnerability findings across 3 advisories, all in transitive dependencies that can't be upgraded without a Tauri stack bump:(The other 22 findings are unmaintained-crate warnings —
cargo auditnever failed on those.)Change
.cargo/audit.tomlwith the 3 advisory ignores (this is the filecargo auditreads).src-tauri/deny.tomlso the two ignore lists stay in sync (the quick-xml pair was already there).Verification
Both exit 0 locally:
cargo audit→warning: 22 allowed warnings found(no errors)cargo deny check→advisories ok, bans ok, licenses ok, sources okNote on overlap with
fix/workspace-lockfile-syncThat branch already introduces
.cargo/audit.toml, but with only the two quick-xml IDs — it's now missing RUSTSEC-2026-0204 (published more recently), so it would no longer fully pass on its own. This PR is the minimal standalone unblock; if it merges first, the lockfile-sync branch should take this file's 3-ID version (or drop its own copy). Merge order is a trivial add/add on one file.Once this lands on
main, updating the other open PRs (#241–#245) withmainturns their audit step green and lets the platform builds run.🤖 Generated with Claude Code