Fix cfg target syntax and Windows-only wording in SYNCML_WORKSPACE_PROPOSAL - #14
Merged
adamgell merged 2 commits intoMar 16, 2026
Merged
Conversation
Co-authored-by: adamgell <27519+adamgell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add SyncML Workspace proposal: port SyncMLViewer to Rust/Tauri
Fix cfg target syntax and Windows-only wording in SYNCML_WORKSPACE_PROPOSAL
Mar 16, 2026
adamgell
marked this pull request as ready for review
March 16, 2026 20:19
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SyncML workspace proposal document to correct platform-gating details so the proposal matches how this repo already handles Windows-only functionality (e.g., dsregcmd commands) and Cargo target-specific dependencies.
Changes:
- Fix the Cargo.toml snippet to use
[target.'cfg(target_os = "windows")'.dependencies](matching the repo’s existing pattern). - Clarify that only ETW capture/trigger commands are Windows-gated; the SyncML workspace UI can remain cross-platform with ETW actions disabled/hidden on non-Windows.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two inaccuracies in the SyncML workspace proposal flagged during review.
Changes
cfgtarget syntax: Replacecfg(windows)withcfg(target_os = "windows")in the Cargo.toml snippet to match the repo's established convention (e.g., the existingwinregdependency section).Windows-only scope clarification: The original note implied the entire SyncML workspace must be Windows-only (analogizing to dsregcmd). Corrected to reflect that only the ETW capture/trigger commands are Windows-gated; the workspace UI can exist cross-platform with those actions disabled/hidden on non-Windows — consistent with how the dsregcmd workspace actually behaves.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.