Skip to content

Fix cfg target syntax and Windows-only wording in SYNCML_WORKSPACE_PROPOSAL - #14

Merged
adamgell merged 2 commits into
claude/syncml-viewer-rust-port-mFaHffrom
copilot/sub-pr-12
Mar 16, 2026
Merged

Fix cfg target syntax and Windows-only wording in SYNCML_WORKSPACE_PROPOSAL#14
adamgell merged 2 commits into
claude/syncml-viewer-rust-port-mFaHffrom
copilot/sub-pr-12

Conversation

Copilot AI commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Two inaccuracies in the SyncML workspace proposal flagged during review.

Changes

  • cfg target syntax: Replace cfg(windows) with cfg(target_os = "windows") in the Cargo.toml snippet to match the repo's established convention (e.g., the existing winreg dependency section).

  • Windows-only scope clarification: The original note implied the entire SyncML workspace must be Windows-only (analogizing to dsregcmd). Corrected to reflect that only the ETW capture/trigger commands are Windows-gated; the workspace UI can exist cross-platform with those actions disabled/hidden on non-Windows — consistent with how the dsregcmd workspace actually behaves.

# Before
[target.'cfg(windows)'.dependencies]

# After
[target.'cfg(target_os = "windows")'.dependencies]

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: adamgell <27519+adamgell@users.noreply.github.com>
Copilot AI changed the title [WIP] Add SyncML Workspace proposal: port SyncMLViewer to Rust/Tauri Fix cfg target syntax and Windows-only wording in SYNCML_WORKSPACE_PROPOSAL Mar 16, 2026
Copilot AI requested a review from adamgell March 16, 2026 15:24
@adamgell
adamgell marked this pull request as ready for review March 16, 2026 20:19
Copilot AI review requested due to automatic review settings March 16, 2026 20:19
@adamgell
adamgell merged commit 95bfcf7 into claude/syncml-viewer-rust-port-mFaHf Mar 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SyncML workspace proposal document to correct platform-gating details so the proposal matches how this repo already handles Windows-only functionality (e.g., dsregcmd commands) and Cargo target-specific dependencies.

Changes:

  • Fix the Cargo.toml snippet to use [target.'cfg(target_os = "windows")'.dependencies] (matching the repo’s existing pattern).
  • Clarify that only ETW capture/trigger commands are Windows-gated; the SyncML workspace UI can remain cross-platform with ETW actions disabled/hidden on non-Windows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants