Verify that request is not null. #362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjallday
reviewed
Mar 30, 2017
| @@ -443,7 +443,7 @@ void respond(ProxyToServerConnection serverConnection, HttpFilters filters, | |||
| // if this HttpResponse does not have any means of signaling the end of the message body other than closing | |||
| // the connection, convert the message to a "Transfer-Encoding: chunked" HTTP response. This avoids the need | |||
| // to close the client connection to indicate the end of the message. (Responses to HEAD requests "must be" empty.) | |||
| if (!ProxyUtils.isHEAD(currentHttpRequest) && !ProxyUtils.isResponseSelfTerminating(httpResponse)) { | |||
| if ((currentHttpRequest != null && !ProxyUtils.isHEAD(currentHttpRequest)) && !ProxyUtils.isResponseSelfTerminating(httpResponse)) { | |||
There was a problem hiding this comment.
i think there is one set of redundant parenthesis here.
|
@yuriyshafranyuk1 I think issue #360 was later fixed in e65c33d3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #360.