Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fork #1

Merged
merged 5,190 commits into from
May 27, 2021
Merged

Update fork #1

merged 5,190 commits into from
May 27, 2021

Conversation

adam-tylr
Copy link
Owner

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...
``` m

bill-rich and others added 30 commits May 19, 2021 15:47
…viderlint/github.com/aws/aws-sdk-go-1.38.43

build(deps): bump github.com/aws/aws-sdk-go from 1.38.42 to 1.38.43 in /awsproviderlint
…ructure/repository/hashicorp/github-4.9.4

build(deps): bump hashicorp/github from 3.1.0 to 4.9.4 in /infrastructure/repository
…t_commenter-removal

hashibot: Remove deprecated_import_commenter behavior
…ker-migration

hashibot: Migrate closed_issue_locker behavior to GitHub Actions
Reference: #19356

Lift and shift of existing labeling configuration with conversion to YAML syntax.
ewbankkit and others added 25 commits May 26, 2021 16:49
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasDiscoverer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasDiscoverer_ -timeout 180m
=== RUN   TestAccAWSSchemasDiscoverer_basic
=== PAUSE TestAccAWSSchemasDiscoverer_basic
=== RUN   TestAccAWSSchemasDiscoverer_disappears
=== PAUSE TestAccAWSSchemasDiscoverer_disappears
=== RUN   TestAccAWSSchemasDiscoverer_Description
=== PAUSE TestAccAWSSchemasDiscoverer_Description
=== RUN   TestAccAWSSchemasDiscoverer_Tags
=== PAUSE TestAccAWSSchemasDiscoverer_Tags
=== CONT  TestAccAWSSchemasDiscoverer_basic
=== CONT  TestAccAWSSchemasDiscoverer_Tags
=== CONT  TestAccAWSSchemasDiscoverer_Description
=== CONT  TestAccAWSSchemasDiscoverer_disappears
--- PASS: TestAccAWSSchemasDiscoverer_disappears (14.58s)
--- PASS: TestAccAWSSchemasDiscoverer_basic (17.70s)
--- PASS: TestAccAWSSchemasDiscoverer_Tags (40.38s)
--- PASS: TestAccAWSSchemasDiscoverer_Description (40.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.537s
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasRegistry_ -timeout 180m
=== RUN   TestAccAWSSchemasRegistry_basic
=== PAUSE TestAccAWSSchemasRegistry_basic
=== RUN   TestAccAWSSchemasRegistry_disappears
=== PAUSE TestAccAWSSchemasRegistry_disappears
=== RUN   TestAccAWSSchemasRegistry_Description
=== PAUSE TestAccAWSSchemasRegistry_Description
=== RUN   TestAccAWSSchemasRegistry_Tags
=== PAUSE TestAccAWSSchemasRegistry_Tags
=== CONT  TestAccAWSSchemasRegistry_basic
=== CONT  TestAccAWSSchemasRegistry_Tags
=== CONT  TestAccAWSSchemasRegistry_Description
=== CONT  TestAccAWSSchemasRegistry_disappears
--- PASS: TestAccAWSSchemasRegistry_disappears (10.49s)
--- PASS: TestAccAWSSchemasRegistry_basic (16.15s)
--- PASS: TestAccAWSSchemasRegistry_Description (36.82s)
--- PASS: TestAccAWSSchemasRegistry_Tags (37.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.482s
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasSchema_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasSchema_ -timeout 180m
=== RUN   TestAccAWSSchemasSchema_basic
=== PAUSE TestAccAWSSchemasSchema_basic
=== RUN   TestAccAWSSchemasSchema_disappears
=== PAUSE TestAccAWSSchemasSchema_disappears
=== RUN   TestAccAWSSchemasSchema_ContentDescription
=== PAUSE TestAccAWSSchemasSchema_ContentDescription
=== RUN   TestAccAWSSchemasSchema_Tags
=== PAUSE TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasSchema_basic
=== CONT  TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasSchema_disappears
=== CONT  TestAccAWSSchemasSchema_ContentDescription
--- PASS: TestAccAWSSchemasSchema_disappears (13.71s)
--- PASS: TestAccAWSSchemasSchema_basic (17.04s)
--- PASS: TestAccAWSSchemasSchema_Tags (39.01s)
--- PASS: TestAccAWSSchemasSchema_ContentDescription (39.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.503s
Add support for Eventbridge Schema Registry, Discoverer and Schema resources
aws_ec2_capacity_reservation outpost_arn attribute support
….com/aws/aws-sdk-go-1.38.49

build(deps): bump github.com/aws/aws-sdk-go from 1.38.48 to 1.38.49
…viderlint/github.com/aws/aws-sdk-go-1.38.49

build(deps): bump github.com/aws/aws-sdk-go from 1.38.48 to 1.38.49 in /awsproviderlint
Add tags argument to resource/aws_elasticache_parameter_group
@adam-tylr adam-tylr merged commit 36bf61a into adam-tylr:master May 27, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @adam-tylr 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.