Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shared-bindings/i2ctarget/I2CTarget.c: add finaliser #9810

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Nov 14, 2024

Tested with test mentioned in #9809.

EDIT: remove self type checks that were not needed. Add checks for deinit for safety. Similar checks are in other classes, such as I2C. Make fit on feather_m4_can.

Copy link
Member

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks

@dhalbert dhalbert merged commit 60d6336 into adafruit:main Nov 18, 2024
16 checks passed
@dhalbert dhalbert deleted the i2ctarget-finaliser branch November 19, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I2CTarget not being deinited properly on soft restart
2 participants