Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serial REPL bootloop for raspberrypi pico boards #9799

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

eightycc
Copy link

@eightycc eightycc commented Nov 8, 2024

An extra call to serial_early_init() causes builds with serial REPL enabled to enter a bootloop. Affects all port raspberrypi boards.

Regression due to #9490, looks like a leftover from debug.

Tested with raspberrypi_pico_w and adafruit_feather_rp2350 covering serial REPL enabled and disabled cases.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@dhalbert dhalbert merged commit 6d32c56 into adafruit:main Nov 8, 2024
137 checks passed
@eightycc eightycc deleted the bootloop branch November 8, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants