Force inline critical_section_{enter,exit} from SDK#10219
Merged
dhalbert merged 1 commit intoadafruit:mainfrom Apr 2, 2025
Merged
Force inline critical_section_{enter,exit} from SDK#10219dhalbert merged 1 commit intoadafruit:mainfrom
dhalbert merged 1 commit intoadafruit:mainfrom
Conversation
These are used by USB host on core 1 and must be in RAM to work. The softer `inline` keyword allows the compiler to ignore it and put the function in flash instead. Core 1 will crash then.
dhalbert
approved these changes
Apr 2, 2025
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
👍
Note that upstream PR is revised from the commit here a bit, and adds an #include which isn't needed in our particular case. We'll want to update to pico-sdk 2.1.2 when that PR is accepted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are used by USB host on core 1 and must be in RAM to work. The softer
inlinekeyword allows the compiler to ignore it and put the function in flash instead. Core 1 will crash then.Upstream PR is here: raspberrypi/pico-sdk#2393