Fixes to RP2350 Framebuffer and handling of flash writes#10116
Merged
tannewt merged 3 commits intoadafruit:mainfrom Mar 11, 2025
Merged
Fixes to RP2350 Framebuffer and handling of flash writes#10116tannewt merged 3 commits intoadafruit:mainfrom
tannewt merged 3 commits intoadafruit:mainfrom
Conversation
Fix miscellaneous memory leaks. Minor code cleanup in RP2350 framebuffer. Factor teardown of partially constructed Framebuffer object.
…supervisor_flash_post_write. Remove redundant xip cache clean, psram state preservation.
tannewt
previously approved these changes
Mar 6, 2025
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Looks good! I'm happy to merge this to make testing easier. Thanks!
Collaborator
Author
|
Corrected an additional issue in original code with DMA command buffer allocation. Moved to "ready for review". I've been running on RP2350 with PSRAM for a few days with no issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a small package of fixes made while resolving #10104:
common_hal_mcu_enable_interrupts().supervisor_flash_pre_write()andsupervisor_flash_post_write().I'm submitting this as a draft to allow more testing.